Optionally group digits of RF energy storage#38
Merged
Dream-Master merged 3 commits intoGTNewHorizons:masterfrom Jun 20, 2025
Merged
Optionally group digits of RF energy storage#38Dream-Master merged 3 commits intoGTNewHorizons:masterfrom
Dream-Master merged 3 commits intoGTNewHorizons:masterfrom
Conversation
Ruling-0
reviewed
Jun 18, 2025
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerEnergyCell.java
Outdated
Show resolved
Hide resolved
src/main/java/mcp/mobius/waila/addons/thermalexpansion/HUDHandlerIEnergyHandler.java
Outdated
Show resolved
Hide resolved
Ruling-0
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the optional decimal formatting of RFEnergyStorage (HUDHandlerIEnergyHandler) and Energy Transfer (HUDHandlerEnergyCell) to enable digit grouping.
I've been using this back with Waila, and it has been a nice QOL Feature, enabling quicker reading.
In practice, it looks like this:
Since some players probably find this change dubious, I've left it disabled by default for now.
In terms of locale, normally DecimalFormatSybols should pick up the correct separator by default, but I'm missing the knowledge there in how minecraft/forge provides the current locale to mods (Maybe we do it with language files?).