Open
Conversation
SuperSoupr
force-pushed
the
world-conversion
branch
7 times, most recently
from
0e7e8e1 to
5461fc8
Compare
SuperSoupr
force-pushed
the
world-conversion
branch
from
6456b72 to
320ee58
Compare
serenibyss
reviewed
Dec 22, 2025
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
Overall this is very well done, I only have a few minor comments and questions. I have not tested the specific transformations yet, but the core system looks great and I will test out each transformation in a review in the next few days
src/main/java/com/fouristhenumber/utilitiesinexcess/compat/exu/Remappings.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/compat/exu/ExuCompat.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/compat/nei/NEIUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/config/OtherConfig.java
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/compat/exu/postea/DummyBlock.java
Show resolved
Hide resolved
Contributor
Author
Thank you, I'm glad to hear the time I put into planning it paid off :) |
Collaborator
|
I know there are some potential changes coming to postea's api that will require this to be looked at again, but will merge for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished everything currently in the mod, remaining features can be added as they get implemented.
I recommend just looking at the first commit since that has just enough to make it clear what I'm going for. I abstracted as
much of the postea and missing mapping registration as I could to make it easier to just write the transforming code.