-
Notifications
You must be signed in to change notification settings - Fork 203
Remove Unused Code #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove Unused Code #1581
+298
−860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
danyadev
requested changes
Jan 31, 2026
src/main/java/com/dreammaster/command/HazardousItemsCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreammaster/modhazardousitems/HazardousItemsHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dreammaster/modhazardousitems/HazardousItemsHandler.java
Show resolved
Hide resolved
Contributor
Author
|
I am going to draft this PR and split it up into many smaller PRs. |
Member
|
I think there's no need for it, I've looked through every commit, they were split good enough |
Contributor
Author
I am sorry about that. Feel free to approve the individual PRs, though! |
# Conflicts: # src/main/java/com/dreammaster/config/CoreModConfig.java
danyadev
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
NotificationTickHandlerfor providing achievement-like popups to the player.use_machine_metal_tintGT config, since it wasn't correctly implemented anyways and there are better ways to change the machine metal tint color.To remove in future PRs:
MinetweakerFurnaceFixto a mixin in HodgepodgeShould be merged alongside GTNewHorizons/GT-New-Horizons-Modpack#23384