-
Notifications
You must be signed in to change notification settings - Fork 86
fix(render): unflip texture on bottom face of blocks #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a mixin to fix the texture UV on the vanilla rendering code for the bottom face of blocks. This relates to MC-47811 which was later fixed in MC 1.8+.
Alexdoru
reviewed
Nov 27, 2025
...main/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinRenderBlocks_FaceYNegUV.java
Outdated
Show resolved
Hide resolved
...main/java/com/mitchej123/hodgepodge/mixins/early/minecraft/MixinRenderBlocks_FaceYNegUV.java
Outdated
Show resolved
Hide resolved
Alexdoru
reviewed
Nov 27, 2025
src/main/java/com/mitchej123/hodgepodge/config/TweaksConfig.java
Outdated
Show resolved
Hide resolved
leagris
added a commit
to GTNewHorizons/GT5-Unofficial
that referenced
this pull request
Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 This conditionnally disables the workaround for the vanilla bug when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris
added a commit
to leagris/GT5-Unofficial-GTNH
that referenced
this pull request
Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 This conditionnally disables the workaround for the vanilla bug when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris
added a commit
to leagris/GT5-Unofficial-GTNH
that referenced
this pull request
Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 This conditionnally disables the workaround for the vanilla bug when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris
added a commit
to GTNewHorizons/Applied-Energistics-2-Unofficial
that referenced
this pull request
Nov 30, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 This conditionnally disables the workaround for the vanilla bug when the hodgepodge FixesConfig.fixBottomFaceUV = true
7 tasks
leagris
added a commit
to GTNewHorizons/OpenComputers
that referenced
this pull request
Jan 2, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 When unflipped, the bottom face connected textures of the multi-block screen nees a new unflipped order to correctly connect.
leagris
added a commit
to GTNewHorizons/Chisel
that referenced
this pull request
Jan 14, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 When unflipped, the bottom face of v-type connected textures blocks like the large hexplating or the Industrial Technical Block's massive big fan, needs a new unflipped order to correctly connect. Consequently, when `fixBottomFaceUV=true`, the bottom fan animation rotates the same way as other faces, instead of backward without the hodgepodge fix.
Now that most if not all potentially affected mods have been reviewed, it is safe to enable the fix by default. The worst that can happen is funny rendering of bottom face UV or wrong connected texture order without any functional impact at all.
wlhlm
approved these changes
Jan 16, 2026
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
Chisel has been addressed (see task list in the description) |
leagris
added a commit
to GTNewHorizons/Angelica
that referenced
this pull request
Jan 28, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 When unflipped, the bottom face of the CTM connected textures needs an unflipped East-West order to correctly connect.
leagris
added a commit
to GTNewHorizons/GT5-Unofficial
that referenced
this pull request
Jan 28, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV. See: GTNewHorizons/Hodgepodge#676 Bottom face of dimension display now unflipped when fixBottomFaceUV is true, otherwise flip the icon to workaround vanilla bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Mixin to fix the texture UV on the vanilla rendering code for the bottom face of blocks.
This relates to MC-47811 which was later fixed in MC 1.8+.
The fix is toggled with this option in
config/hodgepodge.cfg:For now it defaults to false because some mods using the vanilla
RenderBlocks.renderFaceYNegmethod, implemented a work-around to unflip the texture when orientation matters on the bottom face (eg.: symbols, cardinal markings…).Reviewers: Please help identifying the mods needing an update for when this patch is enabled.
Checked/Fixed mods
No fix neededNo fix neededNo fix neededNo fix neededNo fix neededNo fix neededNo fix neededNo fix neededAuthors choose to not bother with connected textures at bottom side.No fix neededNo fix neededbut discovered and fixed issue with bottom UV: Fix(render): Bottom face rotation and UV StorageDrawers#58