Skip to content

Conversation

@leagris
Copy link
Contributor

@leagris leagris commented Nov 27, 2025

Adds a Mixin to fix the texture UV on the vanilla rendering code for the bottom face of blocks.
This relates to MC-47811 which was later fixed in MC 1.8+.

FixBottomUV

The fix is toggled with this option in config/hodgepodge.cfg:

    # Do not flip bottom face textures (1.8+ behavior, see MC-47811) [default: false]
    B:fixBottomFaceUV=true

For now it defaults to false because some mods using the vanilla RenderBlocks.renderFaceYNeg method, implemented a work-around to unflip the texture when orientation matters on the bottom face (eg.: symbols, cardinal markings…).

Reviewers: Please help identifying the mods needing an update for when this patch is enabled.

Checked/Fixed mods

Adds a mixin to fix the texture UV on the vanilla rendering code
for the bottom face of blocks.
This relates to MC-47811 which was later fixed in MC 1.8+.
@leagris leagris requested review from a team, Alexdoru and mitchej123 November 27, 2025 13:35
@leagris leagris added help wanted Extra attention is needed compatibility Compatibility with other mods labels Nov 27, 2025
@leagris leagris requested a review from Alexdoru November 27, 2025 18:56
leagris added a commit to GTNewHorizons/GT5-Unofficial that referenced this pull request Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom
face texture UV.
See: GTNewHorizons/Hodgepodge#676

This conditionnally disables the workaround for the vanilla bug
when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris added a commit to leagris/GT5-Unofficial-GTNH that referenced this pull request Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom
face texture UV.
See: GTNewHorizons/Hodgepodge#676

This conditionnally disables the workaround for the vanilla bug
when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris added a commit to leagris/GT5-Unofficial-GTNH that referenced this pull request Nov 28, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom
face texture UV.
See: GTNewHorizons/Hodgepodge#676

This conditionnally disables the workaround for the vanilla bug
when the hodgepodge FixesConfig.fixBottomFaceUV = true
leagris added a commit to GTNewHorizons/Applied-Energistics-2-Unofficial that referenced this pull request Nov 30, 2025
Incomming HodgePodge mixin fixBottomFaceUV options fixes the bottom
face texture UV.
See: GTNewHorizons/Hodgepodge#676

This conditionnally disables the workaround for the vanilla bug
when the hodgepodge FixesConfig.fixBottomFaceUV = true
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 8, 2025
leagris added a commit to GTNewHorizons/OpenComputers that referenced this pull request Jan 2, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV.
See: GTNewHorizons/Hodgepodge#676

When unflipped, the bottom face connected textures of the multi-block screen
nees a new unflipped order to correctly connect.
leagris added a commit to GTNewHorizons/Chisel that referenced this pull request Jan 14, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV.
See: GTNewHorizons/Hodgepodge#676

When unflipped, the bottom face of v-type connected textures blocks like the
large hexplating or the Industrial Technical Block's massive big fan, needs
a new unflipped order to correctly connect.
Consequently, when `fixBottomFaceUV=true`, the bottom fan animation rotates
the same way as other faces, instead of backward without the hodgepodge fix.
Now that most if not all potentially affected mods have been reviewed,
it is safe to enable the fix by default.
The worst that can happen is funny rendering of bottom face UV or
wrong connected texture order without any functional impact at all.
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. This may require some tweaking in some mods, like Chisel, but after deliberation (see Discord), I think it should be manageable and so we can leave this enabled by default.

@leagris leagris merged commit 616aafb into master Jan 16, 2026
1 check passed
@leagris leagris deleted the fixBottomUV branch January 16, 2026 01:26
@leagris
Copy link
Contributor Author

leagris commented Jan 16, 2026

Implementation looks good. This may require some tweaking in some mods, like Chisel,

Chisel has been addressed (see task list in the description)

@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 24, 2026
leagris added a commit to GTNewHorizons/Angelica that referenced this pull request Jan 28, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV.
See: GTNewHorizons/Hodgepodge#676

When unflipped, the bottom face of the CTM connected textures needs
an unflipped East-West order to correctly connect.
leagris added a commit to GTNewHorizons/GT5-Unofficial that referenced this pull request Jan 28, 2026
HodgePodge mixin fixBottomFaceUV options fixes the bottom face texture UV.
See: GTNewHorizons/Hodgepodge#676

Bottom face of dimension display now unflipped when fixBottomFaceUV is true,
otherwise flip the icon to workaround vanilla bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Compatibility with other mods help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants