Fix the oxygen usage when entering water#121
Merged
Dream-Master merged 2 commits intoGTNewHorizons:masterfrom Jan 9, 2026
Merged
Fix the oxygen usage when entering water#121Dream-Master merged 2 commits intoGTNewHorizons:masterfrom
Dream-Master merged 2 commits intoGTNewHorizons:masterfrom
Conversation
Justxs
reviewed
Jan 5, 2026
Dream-Master
added
the
🚧 Testing on Zeta
Justxs
approved these changes
Jan 9, 2026
sisyphussy
approved these changes
Jan 9, 2026
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, oxygen gets consumed as soon as the player touches water, not just when he actually submerges. Also, oxygen would be consumed if the player already had the water breathing effect active. This PR fixes both of these.
Tested in dev env and seemed to work perfectly fine.
closes GTNewHorizons/GT-New-Horizons-Modpack#20451