Skip to content

Spotless apply for branch fix-packing-bug for #118 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

Spotless apply for branch fix-packing-bug for #118 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/micdoodle8/mods/galacticraft/core/util/RelativeCoordinatePacker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
/**
* Packs relative coordinates into an int with optional side bits. Layout: [6 side bits][8 Y][9 Z][9 X]
* <p>
* Valid range: X/Z: -256 to +255 (9-bit signed), Y: -128 to +127 (8-bit signed).
* Values outside this range will silently wrap due to masking.
* Valid range: X/Z: -256 to +255 (9-bit signed), Y: -128 to +127 (8-bit signed). Values outside this range will
* silently wrap due to masking.
*/
public final class RelativeCoordinatePacker {

Expand Down
10 changes: 3 additions & 7 deletions src/test/java/micdoodle8/mods/galacticraft/core/util/RelativeCoordinatePackerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,10 @@ public class RelativeCoordinatePackerTest {
@Test
void testPackUnpackRoundTrip() {
// X/Z: 9-bit signed (-256 to +255), Y: 8-bit signed (-128 to +127)
int[][] coords = {
{ 0, 0, 0 }, { 1, 0, 0 }, { 0, 1, 0 }, { 0, 0, 1 },
{ -1, 0, 0 }, { 0, -1, 0 }, { 0, 0, -1 }, { -1, -1, -1 },
{ 31, 31, 31 }, { -32, -32, -32 }, { -15, 10, -20 },
int[][] coords = { { 0, 0, 0 }, { 1, 0, 0 }, { 0, 1, 0 }, { 0, 0, 1 }, { -1, 0, 0 }, { 0, -1, 0 }, { 0, 0, -1 },
{ -1, -1, -1 }, { 31, 31, 31 }, { -32, -32, -32 }, { -15, 10, -20 },
// Extended range tests
{ 255, 127, 255 }, { -256, -128, -256 },
{ 100, -50, -200 }, { -200, 100, 150 },
};
{ 255, 127, 255 }, { -256, -128, -256 }, { 100, -50, -200 }, { -200, 100, 150 }, };
for (int[] c : coords) {
int packed = RelativeCoordinatePacker.pack(c[0], c[1], c[2]);
assertEquals(c[0], RelativeCoordinatePacker.unpackX(packed), "X for " + c[0]);
Expand Down