Fix coordinate packing bug in ArcLamp#118
Merged
mitchej123 merged 4 commits intomasterfrom Dec 16, 2025
Merged
Conversation
mitchej123
commented
Dec 16, 2025
mitchej123
commented
- Adds a small RelativeCoordinatePacker w/ tests
- Use relative offsets + side in ints instead of a long from CoordinatePacker
- Fixes a bug where lightArea wouldn't re-add existing bright air so things wouldn't get cleaned up when broken properly
* Adds a small RelativeCoordinatePacker w/ tests * Use relative offsets + side in ints instead of a long from CoordinatePacker * Fixes a bug where lightArea wouldn't re-add existing bright air so things wouldn't get cleaned up when broken properly
dvdmandt
approved these changes
Dec 16, 2025
dvdmandt
left a comment
dvdmandt
left a comment
There was a problem hiding this comment.
Looks like a good fix for now. I think the RelativeCoordinatePacker should eventually be moved to GTNHLib as it seems really useful to have as a generic component, possibly with variable bits for coords and "extra" (like the direction bits in this case). But that's for a later discussion, for now, this looks good and fixes the problem with Arc Lamps.
7 tasks
boubou19
pushed a commit
that referenced
this pull request
Dec 22, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.