-
Notifications
You must be signed in to change notification settings - Fork 450
Add Compressed + Quantum Busses #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
chrombread
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments.
src/main/java/gregtech/common/gui/modularui/hatch/MTEHatchInputBusCompressedGui.java
Outdated
Show resolved
Hide resolved
| return new ModularPanel("busSettings") | ||
| .relative(parent) | ||
| .rightRel(1) | ||
| .bottom(50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be toprel(0.8f) or something but nonissue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did bottom + pixels so that it always lines up with the player inventory, idk if there's a better way of doing that.
src/main/java/gregtech/common/gui/modularui/hatch/MTEHatchOutputBusCompressedGui.java
Outdated
Show resolved
Hide resolved
| amount); | ||
| } | ||
|
|
||
| private static BigInteger parseEU(String eu) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this parse eu code intended to be a part of this pr? seems unreleated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can pull it out but I kept getting annoyed by having to put in a bunch of zeros for the EoH power so I included this here.
See #5026 for more info on this.
depends on: GTNewHorizons/Avaritia#69depends on: GTNewHorizons/ModularUI2#89