Skip to content

Fix Universium shader crash#12

Open
sisyphussy wants to merge 6 commits intomasterfrom
fix-universium
Open

Fix Universium shader crash#12
sisyphussy wants to merge 6 commits intomasterfrom
fix-universium

Conversation

@sisyphussy
Copy link

No longer creates another ShaderProgram that's basically identical to the one in Avaritia

Also a rendering code cleanup (there were some unholy things going on here)

Closes GTNewHorizons/GT-New-Horizons-Modpack#22968

2025-12-23_15 31 14 2025-12-23_16 27 02

@github-actions
Copy link

#13

Co-authored-by: GitHub GTNH Actions <>
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change introduce a requirement on a specific min version of Avaritia? If so, please specify this in the @Mod annotation.

@sisyphussy
Copy link
Author

If so, please specify this in the @Mod annotation.

Need GTNewHorizons/Avaritia#67 merged first then.

@sisyphussy
Copy link
Author

Actually nvm, newer versions are still compatible with older avaritia versions since I'm using the shader from GTNHLib now. It's just older versions not being compatible with newer avaritia versions.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 23, 2025
@glowredman
Copy link
Member

Then you'll have to

  • mark GTNHLib as required mod here (including the appropriate version)
  • mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

@sisyphussy
Copy link
Author

  • mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

wouldn't this mean eternal singularity is a hard dep on avaritia?

@glowredman
Copy link
Member

No, before/after are only for load order and (if present) version requirements ("if that mod is present, it must be in this range. Hard deps are either required-after or required-before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All singularities from "eternal singularity" are shown as fire in NEI

3 participants