Open
Conversation
glowredman
reviewed
Dec 23, 2025
Member
glowredman
left a comment
There was a problem hiding this comment.
Does this change introduce a requirement on a specific min version of Avaritia? If so, please specify this in the @Mod annotation.
Author
Need GTNewHorizons/Avaritia#67 merged first then. |
Author
|
Actually nvm, newer versions are still compatible with older avaritia versions since I'm using the shader from GTNHLib now. It's just older versions not being compatible with newer avaritia versions. |
Member
|
Then you'll have to
|
Author
wouldn't this mean eternal singularity is a hard dep on avaritia? |
Member
|
No, before/after are only for load order and (if present) version requirements ("if that mod is present, it must be in this range. Hard deps are either required-after or required-before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer creates another ShaderProgram that's basically identical to the one in Avaritia
Also a rendering code cleanup (there were some unholy things going on here)
Closes GTNewHorizons/GT-New-Horizons-Modpack#22968