Improve CubicPlayerManager and add support for third party modded cubic world generators#46
Conversation
DarkShadow44
left a comment
There was a problem hiding this comment.
A bunch of questions and some points that could need improvement. Please don't resolve those, leave that for me.
…able EBS detection
…ct reference to Cube
|
Also, if it's not too much of an issue can we make sure that we have all the libs we need as required loading stuff in the mod annotation/deps in the dependencies file? I think some people were having issues with that, but I haven't looked into it too much yet and thought you might know what we're missing. |
…ore server is fully loaded
… a height bigger than 256 (was causing issues with ic2 rubber trees)
| return mods; | ||
| } | ||
|
|
||
| public static void beforePopulate(World world, IChunkProvider vanilla) { |
There was a problem hiding this comment.
I'm not exactly sure how I feel about this.
We can either leave it like this or add the mods that we need to add to the vanilaCompatPopulationFakeHeight list.
I'm not sure what's going to best in the long term. I ideally want to have it so that eventually mods do generate stuff outside of the normal world height, but this seems reasonable enough for now I guess as I assume we're going to have to add that manually.
I want some thoughts on this.
There was a problem hiding this comment.
I think it's fine, there are proper interfaces for cubic worldgen now that replace this system. No mod that uses this interface will expect to have blocks outside of 0-255. IC2 rubber trees in specific broke badly, because they'd scan y down from ~1mil to 0, and it killed performance.
Code changes
ICubicWorldProviderinterface, which is used by third party mods to make their dimensions cubic.CubeStackBlockView).Testing done
asprof -d 30 -f profile.html -e alloc GradleStartcommand will make a profile that shows allocations, but asprof only works on linux.See Also
Weird water gradients
Stress test
https://discord.com/channels/181078474394566657/1415607665375313961/1492890103457255564