Fixed hard coding item stacks to 64#51
Fixed hard coding item stacks to 64#51Dream-Master merged 5 commits intoGTNewHorizons:masterfrom Andthehand:master
Conversation
|
Also this is the first time I've worked on any GTNH code so if there's something I'm doing wrong feel free to critique me. |
|
I couldn't reproduce the mentioned issue. Could you tell me how you did it? |
|
All you need is any gregtech mortar and a stack of raw beef then go into a Cooking table and shift click specifically mince meat and you'll see that it uses all of the ingredients but never gives you any mince meat in return |
|
Now I can reproduce the issue. However, your patch doesn't fix the issue. |
|
Yes, I never fixed that specific bug since I couldn't figure out the root cause of the issue. Instead I just cleaned up some of the code to feel like I actually did something hoping someone else would have a better idea of how to fix the issue😄. |
|
Oh I see lol |
miozune
left a comment
There was a problem hiding this comment.
Please run spotlessApply to fix formatting issue.
src/main/java/net/blay09/mods/cookingforblockheads/container/ContainerRecipeBook.java
Show resolved
Hide resolved
|
Oh FYI I figured out the cause of the issue. There was a recipe to grind mince meat into mince meat, causing loopback GTNewHorizons/NewHorizonsCoreMod#1203 |
|
Oh dang that's an annoying bug. |
I tried to fix a bug mentioned in this issue I found that when
addItemStackToInventory(craftingResult)is called inContainerRecipeBook::tryCraft()it returns true meaning it should have added the item to your inventory but is never added somehow?If someone has any suggestions I am all ears but for now I just fixed a problem with hardcoding specific stack sizes to 64 when you shift clicking an item inside of the cooking table. Now it defaults to the max stack size of the item that you are trying to make. Also removed some redundant code.