-
Notifications
You must be signed in to change notification settings - Fork 41
Grammar/Spelling Pass #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Holy grind. I cannot believe you had the patience to do this, this took me a few hours to read over during work. I likely missed a couple of things but either way this is MUCH better than what was in before so thank you for the great effort. I pointed out a couple of things that could use attention.
The one thing I didn't pick out was non-capitalized proper nouns of directly referenced items, which is a slight inconsistency (some are some aren't, they propbably should be, like with Magicales, etc etc) I think that would be much easier to correct with a script than have me point out in review.
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
UltraProdigy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more tiny thing and this looks gtm 👍
src/main/resources/assets/alchemicalwizardrybooks/lang/en_US.lang
Outdated
Show resolved
Hide resolved
UltraProdigy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Book Review ✅
Huge Grammar and typo check on the whole BM Book.
A lot to review, most likely still mistakes in this, but this should have catched many of them.