Conversation
|
The machine can be broken with bare hand (drops nothing) |
src/main/java/fox/spiteful/avaritia/items/ItemMatterCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/avaritia/items/ItemMatterCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/fox/spiteful/avaritia/items/ItemMatterCluster.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String getInventoryName() { | ||
| return getBlockType().getLocalizedName(); |
There was a problem hiding this comment.
@Ranzuu will have your soul for this.
There was a problem hiding this comment.
😆 That's okay, I can change it with mui2 themes. But that also have some problems with default theme, so I don't mind it here 👽
There was a problem hiding this comment.
Is this method actually used for anything? I always thought it was just a debug tool.
|
|
||
| @Override | ||
| public boolean canExtractItem(int slotIndex, ItemStack stack, int side) { | ||
| return slotIndex == 0; |
There was a problem hiding this comment.
- Why allow automation to extract Matter Clusters from the machine?
- Why not allow automation to extract the output items from the machine? (Is there any significant limitation preventing it?)
There was a problem hiding this comment.
- No reason in particular, but it's not like it breaks anything
- There isn't much point. Anything that uses the GTNHLib item moving system will be able to extract from the output slot of this machine. I could wire something up that allows EIO to extract from it but the intended use is to use an import bus or a GT conveyor.
There was a problem hiding this comment.
There is a point for people who aren't in GTNH, or those who don't use AE2 for everything. (For instance, I'm not sure if Translocators will be able to interact with this block.)
(I am aware that Avaritia is currently a GTNH-only mod, but that's solely because nobody has separated the GTNH changes from the rest of the mod.)
There was a problem hiding this comment.
Avaritia is actively supported, and this PR adds a hard dep on GTNHLib (which is fine since everyone likely has it already).
I've intentionally ignored people using this outside the pack because this is only meant to be used for supercritical clusters. You can still open small ones by right clicking them, which drops all of the items on the ground. You can only generate supercritical clusters by special machines - right now only compressed/quantum busses generate them when you eject the contents of a slot. Avaritia tools will never generate one, they'll only create clusters containing up to 16k items.
I was looking at adding item moving support for translocators and SFM but those mods were complex so I haven't started that yet. Porting translocators is more viable than porting SFM.
There was a problem hiding this comment.
Avaritia is actively supported, and this PR adds a hard dep on GTNHLib (which is fine since everyone likely has it already).
I've intentionally ignored people using this outside the pack because this is only meant to be used for supercritical clusters. You can still open small ones by right clicking them, which drops all of the items on the ground. You can only generate supercritical clusters by special machines - right now only compressed/quantum busses generate them when you eject the contents of a slot. Avaritia tools will never generate one, they'll only create clusters containing up to 16k items.
I was looking at adding item moving support for translocators and SFM but those mods were complex so I haven't started that yet. Porting translocators is more viable than porting SFM.
There are good reasons for people to want an automatic way of opening non-supercritical clusters, no?
src/main/java/fox/spiteful/avaritia/items/ItemMatterCluster.java
Outdated
Show resolved
Hide resolved
4ecda72 to
fee5251
Compare

The Matter Cluster Decompressor is a machine that converts matter clusters back into items. It's meant for breaking open huge clusters easily since those will be created by several GT machines. This is primarily compressed busses, but breaking other machines (i.e. item pipes) may also drop clusters instead of normal items to prevent thousands of entities from being created. There will be a threshold above which clusters will be dropped instead of normal items (probably around a thousand items).
Clusters can be inserted into the machine normally, but items can only be pulled with GT or AE because it relies on an item source instead of an inventory. Fluids can be pulled by anything, the machine acts as a tank. Decompressors will convert fluid drops inside of clusters back into fluids automatically.
should be merged after: #69 (this PR includes #69 though)