Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Conversation

osamede20
Copy link

first pass at matching new metadata format

@osamede20 osamede20 added the data test case Tickets related to test case and examplar data for proof of concept label Nov 15, 2023
@osamede20 osamede20 requested a review from mikeAdamss November 15, 2023 11:51
@@ -0,0 +1,101 @@
{
"@context": "https://staging.idpd.uk/#ns",
"@id": "https://staging.idpd.uk/datasets/ons-energy-use-fossil-fuels-by-fuel-type-and-industry/editions",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop ons- from the URIs throughout.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ons-dropped from URIs throughout

"email": "mailto:[email protected]"
},
"topics": [
"https://staging.idpd.uk/topics/climatechange",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

climate-change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topic renamed to agriculture-energy-and-environment in line with the 9 topics received

},
"topics": [
"https://staging.idpd.uk/topics/climatechange",
"https://staging.idpd.uk/topics/carbonemissions"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a theme on the catalogue? Might be wrong tho. If it is, it would be carbon-emissions but double check.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topic renamed to agriculture-energy-and-environment in line with the 9 topics received

"topics": [
"https://staging.idpd.uk/topics/climatechange",
"https://staging.idpd.uk/topics/carbonemissions"],
"frequency": "irregular",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not released regularly? Like annually or something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oversight; from an existing example.
frequency changed to annual

"table_schema": {
"columns": [
{
"name": "Year",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see a CSV file with this PR, but would want to make the CSV headers snake_case

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand URIs are not required on the output CSV file; I'm still trying to understand how this api-poc works as I have been on leave.

Not sure how it works with this particular dataset - with Standard Industrial Classification (SIC) and a local codelist, but I have left URIs on the Section column of the CSV file.

I can remove the URIs from the output CSV, but would obviously require re-transforming the dataset. I am open to doing this.
Thanks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back :)

Yes please - make the changes as needed. With things like SIC codes it might be best to have two columns - one with the code (e.g. A, B or 01 or whatever) and on with the label (Manufacturing)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks.
Great; I will get this done shortly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made as directed - 'Section Notation' and 'Industry Section Name'.

Please let me know if I have missed anything. Thanks.

"columns": [
{
"name": "Year",
"datatype": "xsd:datetime",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime not xsd:datetime

In theory they are the same but the xsd: isn't needed here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed as directed

},
{
"name": "Value",
"datatype": "xsd:decimal",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decimal not xsd:decimal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to decimal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

data test case Tickets related to test case and examplar data for proof of concept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants