-
Notifications
You must be signed in to change notification settings - Fork 0
ONS-Energy-use-fossil-fuels-by-fuel-type-and-industry #137
base: main
Are you sure you want to change the base?
ONS-Energy-use-fossil-fuels-by-fuel-type-and-industry #137
Conversation
@@ -0,0 +1,101 @@ | |||
{ | |||
"@context": "https://staging.idpd.uk/#ns", | |||
"@id": "https://staging.idpd.uk/datasets/ons-energy-use-fossil-fuels-by-fuel-type-and-industry/editions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop ons-
from the URIs throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ons-dropped from URIs throughout
"email": "mailto:[email protected]" | ||
}, | ||
"topics": [ | ||
"https://staging.idpd.uk/topics/climatechange", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
climate-change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topic renamed to agriculture-energy-and-environment
in line with the 9 topics received
}, | ||
"topics": [ | ||
"https://staging.idpd.uk/topics/climatechange", | ||
"https://staging.idpd.uk/topics/carbonemissions"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is a theme on the catalogue? Might be wrong tho. If it is, it would be carbon-emissions
but double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topic renamed to agriculture-energy-and-environment
in line with the 9 topics received
"topics": [ | ||
"https://staging.idpd.uk/topics/climatechange", | ||
"https://staging.idpd.uk/topics/carbonemissions"], | ||
"frequency": "irregular", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not released regularly? Like annually or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oversight; from an existing example.
frequency changed to annual
"table_schema": { | ||
"columns": [ | ||
{ | ||
"name": "Year", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see a CSV file with this PR, but would want to make the CSV headers snake_case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand URIs are not required on the output CSV file; I'm still trying to understand how this api-poc works as I have been on leave.
Not sure how it works with this particular dataset - with Standard Industrial Classification (SIC) and a local codelist, but I have left URIs on the Section column of the CSV file.
I can remove the URIs from the output CSV, but would obviously require re-transforming the dataset. I am open to doing this.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back :)
Yes please - make the changes as needed. With things like SIC codes it might be best to have two columns - one with the code (e.g. A
, B
or 01
or whatever) and on with the label (Manufacturing
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks.
Great; I will get this done shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made as directed - 'Section Notation' and 'Industry Section Name'.
Please let me know if I have missed anything. Thanks.
"columns": [ | ||
{ | ||
"name": "Year", | ||
"datatype": "xsd:datetime", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datetime
not xsd:datetime
In theory they are the same but the xsd:
isn't needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed as directed
}, | ||
{ | ||
"name": "Value", | ||
"datatype": "xsd:decimal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decimal
not xsd:decimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to decimal
first pass at matching new metadata format