make the message more helpful#655
Merged
Merged
Conversation
alanahjonas95
approved these changes
Jul 9, 2026
alanahjonas95
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the update to the message
dragosmg
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
ard_stackusesbind_ardunder the hood, we are now dropping its attributes and not using them for shuffle_card (an oversight in the cards update). This is a regression, since we used to preserve the attributes ofard_stackandbywas not required inshuffle_card. Adding a more explicit message and suggestion to the user to assist in updating their code to match previous behavior.Note that
ard_stack_hierarchicalis not impacted.