Skip to content

make the message more helpful#655

Merged
alanahjonas95 merged 2 commits into
mainfrom
improve-msg
Jul 9, 2026
Merged

make the message more helpful#655
alanahjonas95 merged 2 commits into
mainfrom
improve-msg

Conversation

@bzkrouse

@bzkrouse bzkrouse commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Because ard_stack uses bind_ard under the hood, we are now dropping its attributes and not using them for shuffle_card (an oversight in the cards update). This is a regression, since we used to preserve the attributes of ard_stack and by was not required in shuffle_card. Adding a more explicit message and suggestion to the user to assist in updating their code to match previous behavior.

Note that ard_stack_hierarchical is not impacted.

@alanahjonas95 alanahjonas95 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update to the message

Comment thread R/shuffle_card.R

@dragosmg dragosmg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

@alanahjonas95 alanahjonas95 requested a review from dragosmg July 9, 2026 09:18

@dragosmg dragosmg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@alanahjonas95 alanahjonas95 merged commit c3013e2 into main Jul 9, 2026
11 checks passed
@alanahjonas95 alanahjonas95 deleted the improve-msg branch July 9, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants