Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners update #4706

Merged
merged 2 commits into from
Feb 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
# This file is sensitive since rules below may be used for restricting who can
# make access control changes.
/.github/CODEOWNERS @GSA-TTS/FAC-admins
/.github/workflows/fac-restore-util.yml @GSA-TTS/FAC-admins @asteel-gsa

# Changes to the following CI/CD directories will impact operational systems. Any PR involving these files should
# get a review from someone in FAC-admins
/.github/workflows/ @GSA-TTS/FAC-admins
/backend/manifests/ @GSA-TTS/FAC-admins

# Changes to the following Terraform directory will impact access control in cloud.gov spaces. Any PR involving these files should get a review from someone in FAC-admins.
/terraform/meta/ @GSA-TTS/FAC-admins

# Changes to the following Terraform directories will impact operational systems. Any PR involving these files
# should get a review from someone in FAC-Admins
/terraform/dev/ @GSA-TTS/FAC-admins
/terraform/staging/ @GSA-TTS/FAC-admins
/terraform/preview/ @GSA-TTS/FAC-admins
/terraform/production/ @GSA-TTS/FAC-admins
/terraform/sandbox/ @GSA-TTS/FAC-admins
/terraform/modules/ @GSA-TTS/FAC-admins
25 changes: 12 additions & 13 deletions .github/ISSUE_TEMPLATE/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ assignees: ''

---

**Instructions for the issue creator:**
1. Fill in the GitHub username of the new person (if known) and the name of the onboarding buddy.
**Instructions for the issue creator:**
1. Fill in the GitHub username of the new person (if known) and the name of the onboarding buddy.
1. Remove irrelevant checklists (eg designers should never see the engineer checklist.]
1. Remove the horizontal line below and everything above it (these instructions).

Expand Down Expand Up @@ -37,40 +37,39 @@ Here's a checklist to get you started and to make sure you've got access to :all
Please add my GitHub account (https://github.com/myusername) to the following GitHub organizations:
- https://github.com/GSA
- https://github.com/GSA-TTS
I will be working on the FAC project:
- https://github.com/GSA-TTS/FAC
I have cc'd the FAC Product Lead for awareness.
Thank you!
```
```
- (Note this step could take a few days; humans handle these requests.)
- [ ] Once you are added to the GSA-TTS org, ask [the person(s) with the "Maintainer" role to add you to the `FAC-team` team](https://github.com/orgs/GSA-TTS/teams/fac-team/members). This will grant you read/write access to our repositories.
- [ ] Have the team calendar owner (@jadudm) share the calendar invite link to our new team member.
**For designers, also...**
- [ ] Review the [design onboarding document](https://docs.google.com/document/d/1EILl0nZr59T4PFJJMtFbmnQDJPksgzIFPuoFDN0bk0g/edit#heading=h.bhu3dgydlbvr)
- [ ] Visit https://touchpoints.digital.gov/ and set up a touchpoints account
- [ ] If you don't already have a Figma license, request one from your supervisor.
- [ ] If you don't already have a Figma license, request one from your supervisor.
- [ ] If you don't already have a Mural ccount, follow the instructions to get one [here](https://handbook.tts.gsa.gov/tools/mural/).
**For engineers, also...**
- [ ] Familiarize yourself with Python, Django, and Cloud.gov—all tools used in this project.
- [ ] Familiarize yourself with Python, Django, Docker, Terraform and Cloud.gov—all tools used in this project.
- [ ] If you need to catch up on the latest in Python development, check out the [Python developer's guide](https://devguide.python.org/).
- [ ] Work through the [Django Tutorial](https://docs.djangoproject.com/en/4.0/intro/tutorial01/) and writing your first Django app.
- [ ] If it's not already set up on your machine & account, enable [commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits). Also see the pinned messages in the Slack development channel.
- [ ] If you're not already, get [setup with Cloud.gov](https://cloud.gov/docs/getting-started/setup/)
- [ ] Once your account exists, make a PR to [add yourself to the list of developers](https://github.com/GSA-TTS/FAC/tree/main/terraform/meta/config.tf) with access to our spaces.
- [ ] Practice deploying a [python application](https://github.com/cloud-gov/cf-hello-worlds/tree/main/python-flask) to Cloud.gov using the Cloud.gov command line interface (CLI): https://cloud.gov/docs/getting-started/your-first-deploy/.
- [ ] If you need access to be able to view the cloud.gov interfaces, submit a request with the system owner and access will be provisioned on a case-by-case basis.
- [ ] Practice deploying a [python application](https://github.com/cloud-gov/cf-hello-worlds/tree/main/python-flask) to Cloud.gov using the Cloud.gov command line interface (CLI): https://cloud.gov/docs/getting-started/your-first-deploy/.
- [ ] Survey existing TTS projects which use Django+Cloud.gov like: [Tock](https://github.com/18F/tock) and the [DOJ CRT Portal](https://github.com/usdoj-crt/crt-portal).
- [ ] Get set up for [local development](https://github.com/GSA-TTS/FAC/blob/main/docs/development.md#local-development) so you can start contributing
- [ ] Review [NIST SP 800-161 Rev.1](https://csrc.nist.gov/pubs/sp/800/161/r1/final) on supply chain risk management. Reply to this onboarding ticket in a comment when you have completed this review.
- [ ] Make sure you have a `login.gov` account and have logged into the FAC application at least once.
- [ ] Make sure you have a `login.gov` account and have logged into the FAC application at least once.
- [ ] Then, add your email to the `readonly` list in [staffusers.json](../../backend/config/staffusers.json).
**For helpdesk, also..**
- [ ] Make sure you have a `login.gov` account and have logged into the FAC application at least once.
- [ ] Make sure you have a `login.gov` account and have logged into the FAC application at least once.
- [ ] Then, add your email to the `helpdesk` list in [staffusers.json](../../backend/config/staffusers.json).
Expand Down