Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF Fix + Pagination Fix #4687

Merged
merged 2 commits into from
Feb 5, 2025
Merged

CRLF Fix + Pagination Fix #4687

merged 2 commits into from
Feb 5, 2025

Conversation

asteel-gsa
Copy link
Contributor

@asteel-gsa asteel-gsa commented Feb 5, 2025

looks like my IDE accidentally set this file to CRLF instead of LF

Also fixes an issue with pagination as it was previously loading 1000 keys at a time, and we have.. way more than 1000 items to delete.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #946

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2025-02-05T19:47:48Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

✅ Plan applied in Deploy to Development and Management Environment #946

jperson1
jperson1 previously approved these changes Feb 5, 2025
@asteel-gsa asteel-gsa dismissed jperson1’s stale review February 5, 2025 20:40

Doing a small fix as well

@asteel-gsa asteel-gsa changed the title CRLF Fix [Draft] CRLF Fix + Pagination Fix Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 90%
audit 97% 87%
audit.cross_validation 98% 88%
audit.fixtures 84% 50%
audit.intakelib 91% 82%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 94% 76%
audit.templatetags 100% 100%
audit.views 72% 54%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 77% 37%
curation 100% 100%
curation.curationlib 93% 100%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.migrations 97% 25%
dissemination.searchlib 76% 66%
dissemination.templatetags 100% 100%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 93% 88%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
support 91% 66%
support.migrations 100% 100%
support.models 96% 50%
tools 98% 50%
users 95% 92%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 91% (18265 / 20041) 77% (2267 / 2952)

@asteel-gsa asteel-gsa changed the title [Draft] CRLF Fix + Pagination Fix CRLF Fix + Pagination Fix Feb 5, 2025
@asteel-gsa asteel-gsa added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit d122cc5 Feb 5, 2025
17 checks passed
@asteel-gsa asteel-gsa deleted the crlf-fix branch February 5, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants