Update end-to-end dependencies and workflow, refactor upload specs (#…

…3071) * debug regression workflow * wrong env var setting * update cypress-related deps * turn debug off * set node version * no more retry * browser * fully test on node 20 * info-box timeout * disable leading underscore stylelint check --------- Co-authored-by: Tim Ballard <[email protected]>
GSA-TTS · Jan 4, 2024 · 917bc27 · 917bc27
1 parent a1c2845
commit 917bc27
Show file tree

Hide file tree

Showing 5 changed files with 788 additions and 558 deletions.
diff --git a/.github/workflows/regression-tests.yml b/.github/workflows/regression-tests.yml
@@ -38,23 +38,25 @@ jobs:
       CYPRESS_LOGIN_TEST_OTP_SECRET_AUDITEE: ${{ secrets.CYPRESS_LOGIN_TEST_OTP_SECRET_AUDITEE }}
       DISABLE_AUTH: False
       # useful for debugging but otherwise complete overwhelm
-      # DEBUG: cypress:*
+      # DEBUG: cypress:server:util:process_profiler
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+
       - name: Create .env file
         run: touch .env
 
       - name: Run Cypress full submission test
-        uses: Wandalen/wretry.action@master
+        uses: cypress-io/github-action@v6
         with:
-          action: cypress-io/github-action@v6
-          with: |
-            working-directory: ./backend
-            spec: cypress/e2e/full-submission.cy.js
-          attempt_limit: 5
-          attempt_delay: 2000
+          browser: chrome
+          working-directory: ./backend
+          spec: cypress/e2e/full-submission.cy.js
 
       - uses: actions/upload-artifact@v3
         # add the line below to store screenshots only on failures

diff --git a/backend/.stylelintrc.json b/backend/.stylelintrc.json
@@ -4,6 +4,8 @@
     "selector-class-pattern": null,
     "no-descending-specificity": null,
     "function-no-unknown": null,
-    "media-feature-range-notation": "prefix"
+    "media-feature-range-notation": "prefix",
+    "scss/at-import-no-partial-leading-underscore": null,
+    "scss/load-no-partial-leading-underscore": null
   }
 }
diff --git a/backend/cypress/support/workbook-uploads.js b/backend/cypress/support/workbook-uploads.js
@@ -3,19 +3,20 @@
 // testWorkbookUpload('/audit/excel/federal-awards-expended/*', '#file-input-federal-awards-xlsx', 'federal-awards-expended-UPDATE.xlsx')
 // assumes you are on the appropriate upload page already
 function testWorkbookUpload(interceptUrl, uploadSelector, filename, will_intercept = true) {
-    cy.intercept(interceptUrl + '*', (req) => {
-      if (will_intercept) {
-        // return a success fixture
-        req.reply({ fixture: 'success-res.json' });
-      } else {
-        // with no intercept, don't intervene
-        req.continue();
-      }
+  if (will_intercept) {
+    cy.intercept('POST', interceptUrl + '*', (req) => {
+      req.reply({ fixture: 'success-res.json' });
     }).as('uploadSuccess');
+  } else {
+    cy.intercept('POST', interceptUrl + '*').as('uploadSuccess');
+  }
+
   cy.get(uploadSelector).attachFile(filename);
   // Upload url (POST /audit/excel/workbookname) returns a redirect to "/" on successful upload. So, 302.
-  cy.wait('@uploadSuccess').its('response.statusCode').should('eq', 302);  
-  cy.get('#info_box')
+  cy.wait('@uploadSuccess').should(({request, response}) => {
+    expect(response.statusCode, 'Response status code').to.equal(302);
+  });
+  cy.get('#info_box', { timeout: 10000 })
     .should(
       'have.text',
       'File successfully validated! Your work has been saved.'