Repository navigation
Lab 1: fix three README success signals that don't match real CLI output - #1
Merged
ajy0127 merged 1 commit intoSep 16, 2026
Conversation
- Step 3: create output returns roleDefinitionId (GUID), not roleDefinitionName - Step 4: tell learners to replace you@example.com; that address gets the budget alerts - Verify: --expand alone hides the subscription; --recurse shows the full tree
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ajy0127
added a commit
that referenced
this pull request
Sep 16, 2026
- Lab 3: answer the open question from PR #3 — the deny test now tees its output to lab3-deny-evidence.txt and the text says the raw error (with the Policy identifiers block) is the artifact, not JSON - Lab 5: derive TF_VAR_state_storage_account from backend.hcl (same fix PR #4 made in Lab 4 — the placeholder produced a cryptic 'no such host') - Lab 2: note the one-time log-analytics CLI extension prompt (query block verified live against law-grc-sandbox) - VALIDATION-LOG: F16-F19 recording all four runthrough findings; stage 03 rename verified as a no-op plan against the live environment on azurerm 4.81 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran through Lab 1 end to end on a fresh free account. The setup works and all resources build correctly. Three places in
labs/01-sandbox/README.md, though, tell the learner to look for something the CLI doesn't actually print — each one can make a correct step look broken. Fixes below.1. Step 3 — success signal references a field the command doesn't return
The README says the
az role assignment createoutput showsroleDefinitionName: Reader. It doesn't. The create command only returnsroleDefinitionId, which is a GUID path (ends inacdd72a7-3385-48ef-bd42-f606fba81ae7, the built-in Reader role). A learner scans the output for the word "Reader," never finds it, and reasonably thinks they did the step wrong — even though the assignment is correct.Fix: base the success check on what the output actually contains (
principalType: Group+ the RG-scopedscope), note that the role shows up only asroleDefinitionIdon create, and point toaz role assignment list(or the read-back command already in the step) to see the friendlyroleDefinitionName.2. Step 4 — placeholder email is never flagged for replacement
Step 2 explicitly says "Replace
you@example.comwith your real email." Step 4 shows./create-budget.sh you@example.comwith no such note. That argument becomes thecontactEmailsfor both budget alerts (80% actual, 100% forecast), so a learner who copies it verbatim sends their alerts to a mailbox they don't own and never hears about a runaway.Fix: add the same "replace with your real email" instruction before the command, and say explicitly that this address is where the budget alerts are delivered.
3. Verify checklist #1 — the given command doesn't show the subscription
The first Verify item is
az account management-group show --name mg-grc --expand.--expandonly goes one level, so it showsmg-grc → mg-grc-sandboxbut not the subscription. Since step 1'ssubscription addreturns silently, a learner running this to confirm their work sees no subscription and can't tell whether it attached.Fix: add
--recurseso the command shows all three levels (mg-grc → mg-grc-sandbox → subscription) and actually confirms the silent add worked.All three are documentation-only changes to
labs/01-sandbox/README.md.