-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: Check for NEWS and appdata updates for new releases
At least 4 different bugs were filed against the Flathub version of evince because Flatpak prominently shows the appdata version in the UI, making users think that there was a bug in the packaging, or that the package had not been updated. Avoid this problem in the future by failing the build if the NEWS or appdata files aren't updated on release.
- Loading branch information
Showing
2 changed files
with
99 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
#!/bin/sh | ||
|
||
# Copyright (C) 2019 Red Hat, Inc. | ||
# Author: Bastien Nocera <[email protected]> | ||
# | ||
# This program is free software; you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation; either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program; if not, write to the Free Software | ||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
|
||
|
||
# Add to your top-level meson.build to check for an updated NEWS file | ||
# when doing a "dist" release, similarly to automake's check-news: | ||
# https://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html | ||
# | ||
# Checks NEWS for the version number: | ||
# meson.add_dist_script( | ||
# find_program('check-news.sh').path(), | ||
# '@0@'.format(meson.project_version()) | ||
# ) | ||
# | ||
# Checks NEWS and data/foo.appdata.xml for the version number: | ||
# meson.add_dist_script( | ||
# find_program('check-news.sh').path(), | ||
# '@0@'.format(meson.project_version()), | ||
# 'NEWS', | ||
# 'data/foo.appdata.xml' | ||
# ) | ||
|
||
usage() | ||
{ | ||
echo "$0 VERSION [FILES...]" | ||
exit 1 | ||
} | ||
|
||
check_version() | ||
{ | ||
VERSION=$1 | ||
# Look in the first 15 lines for NEWS files, but look | ||
# everywhere for other types of files | ||
if [ "$2" = "NEWS" ]; then | ||
DATA=`sed 15q $SRC_ROOT/"$2"` | ||
else | ||
DATA=`cat $SRC_ROOT/"$2"` | ||
fi | ||
case "$DATA" in | ||
*"$VERSION"*) | ||
: | ||
;; | ||
*) | ||
echo "$2 not updated; not releasing" 1>&2; | ||
exit 1 | ||
;; | ||
esac | ||
} | ||
|
||
SRC_ROOT=${MESON_DIST_ROOT:-"./"} | ||
|
||
if [ $# -lt 1 ] ; then usage ; fi | ||
|
||
VERSION=$1 | ||
shift | ||
|
||
if [ $# -eq 0 ] ; then | ||
check_version $VERSION 'NEWS' | ||
exit 0 | ||
fi | ||
|
||
for i in $@ ; do | ||
check_version $VERSION "$i" | ||
done | ||
|
||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters