fix(p2p-orderbook): rollback c6c3cc1, f5f0b18 to restore stability#2631
Merged
fix(p2p-orderbook): rollback c6c3cc1, f5f0b18 to restore stability#2631
Conversation
This reverts commit c6c3cc1
Collaborator
|
did the two revertions create any conflicts? Otherwise i can safely skip reviewing them. |
Collaborator
Author
Only the first reversion, conflict was in cargo.toml only. |
shamardy
force-pushed
the
rollback-2605-2580
branch
from
98abd42 to
6f6098d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rolls c6c3cc1 and f5f0b18 back to restore stability of the orderbook functionalities in dev branch. These commits will be added back to #2626 to have one place for duplicate orders and orderbook validation among other p2p network fixes to be tested together.
I think this should be merged without squashing.