fix(Trezor): fix utxo and eth calls due to firmware changes

[dimxy]

Several fixes for interaction with Trezor devices:

• fix DataError returned for segwit calls by specifying the correct input script (relevant to the Legacy models).
• do not use EthereumPublicKey message (broken in firmware) - fixes ETH-like coins activation in KW (relevant to the Trezor Safe model)
• fix serialisation of the address_n field in EVM messages - fixes DataError in the KDF get_new_address call (observed for Safe models)

Partially fixes #2515

[shamardy]

There is an issue for this #2522

[dimxy]

Maybe fix this in a separate PR
(will be a breaking change for the API)

[shamardy]

LGTM!

[shamardy]

@smk762 please check / approve this if it resolves the issues with EVM and segwit coins.

[smk762]

• LTC-segwit now creates correct address format and is accepted without error by the Trezor device for confirmation. ✅

• MATIC activated successfully on Safe 5. ✅

• The task-based scan_for_new_addresses, create_new_account and account_balance RPCs are functioning as expected for ETH/MATIC, but some RPCs return errors, detailed below.

• MATIC task-based address creation fails.

{
    "mmrpc": "2.0",
    "result": {
        "status": "Error",
        "details": {
            "error": "Got data error",
            "error_path": "get_new_address.coin_ops.confirm_address.client",
            "error_trace": "get_new_address:556] coin_ops:198] confirm_address:183] client:95]",
            "error_type": "HwError",
            "error_data": "DataError"
        }
    },
    "id": null
}

• MATIC withdraw attempt without inputting the "from" params led to ambiguous error (should be InvalidParams):

{
    "mmrpc": "2.0",
    "result": {
        "status": "Error",
        "details": {
            "error": "Internal error: DataError",
            "error_path": "eth_withdraw.client",
            "error_trace": "eth_withdraw:473] client:95]",
            "error_type": "InternalError",
            "error_data": "DataError"
        }
    },
    "id": null
}

• With the "from" params included (correct request structure), the same DataError returned :/ (P0 - blocker for approval) 👾

• Legacy disable_coin appears to return success for Trezor activated coin, but coin is present in subsequent v2 get_enabled_coins requests (non-critical, will open new issue for this). 🏈

• The older, non- task get_new_address RPC returns an address in Trezor mode without any interaction to confirm on Trezor. For coins activated in Trezor mode, this RPC should return an error. Trezor should always use https://komodoplatform.com/en/docs/komodo-defi-framework/api/v20/wallet/task_managed/get_new_address/#task-get-new-address-init (non-critical, will open new issue for this) ⛳

[dimxy]

• MATIC task-based address creation fails.
  "error_data": "DataError"

Confirm this error, investigating...

[dimxy]

• MATIC task-based address creation fails.
  "error_data": "DataError"

Fixed MATIC get_new_address DataError in 67604e7 (actually it did not work for all EVM coins)
I also tried withdraw without the "from" param - worked
cc: @smk762

[smk762]

Confirmed working, thanks!

• MATIC/EVM address creation ✔️
• MATIC/EVM withdraw without from ✔️
• MATIC/EVM withdraw with from ✔️

[shamardy]

We now have 2 prost versions which I don't like. I see that latest tendermint-rs version is 0.13 and it looks that this crate is not maintained anymore, as last time a PR was merged was in May. I will leave this as is for now but we need to open an issue for the Tendermint crate and how to deal with it c.c. @onur-ozkan

[onur-ozkan]

They have PRs created very recently so it seems like it's maintained. I sent a PR to them which bumps prost.

[dimxy]

I can downgrade back prost for trezor, if needed (I think this was not needed very much)

[onur-ozkan]

It's fine as we will get the update on tendermint too.

[shamardy]

They have PRs created very recently so it seems like it's maintained. I sent a PR to them which bumps prost.

Last merged PR was in May and the recently opened PRs are not replied to.