feat(core): enable KDF initialization with external wallets#2411
Draft
borngraced wants to merge 23 commits intodevfrom
Draft
feat(core): enable KDF initialization with external wallets#2411borngraced wants to merge 23 commits intodevfrom
borngraced wants to merge 23 commits intodevfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2225
In this PR, I have refactored the way CryptoCtx stores
keypair_ctx,hw_ctxandmetamask_ctxand manageskeypair_ctxI added
no_login_modeflag to kdf config enablingno_login_modeactivation while still havingpassphrase/wallet_name/passwordin config.no_login_modewill initialize CryptoCtx fields state as uninitialized, then we can initialized each contexts with their RPCs (hw_ctx,metamask_ctx,keypair_ctx).I implemented two new rpc methods(
get_crypto_ctxs_stateandinit_crypto_keypair_ctx) for checking initializedCryptoCtxcontexts andinit_crypto_keypair_ctxfor initializingCryptoCtx::keypair_ctx.