Skip to content

Never bind INADDR_ANY by default, and warn when doing so explicitly#667

Open
DeckerSU wants to merge 3 commits intodevfrom
patch-rpcbind_explicit
Open

Never bind INADDR_ANY by default, and warn when doing so explicitly#667
DeckerSU wants to merge 3 commits intodevfrom
patch-rpcbind_explicit

Conversation

@DeckerSU
Copy link

Port of bitcoin/bitcoin#14532 to our codebase.

Similar to: DeckerSU/KomodoOcean#103

@smk762
Copy link

smk762 commented Dec 13, 2025

LGTM.
Confirmed without either or both of rpcbind and rpcallowip

2025-12-13 04:55:38 Loaded Sapling parameters in 1.420968s seconds.
2025-12-13 04:55:38 Binding RPC on address ::1 port 7771 failed.
2025-12-13 04:55:38 Binding RPC on address 127.0.0.1 port 7771 failed.
2025-12-13 04:55:38 Unable to bind any endpoint for RPC server
2025-12-13 04:55:38 Error: Unable to start HTTP server. See debug log for details.

and

smk@jarrah:~/GITHUB/gleec/komodo-daemon$ call komodo_args.(src/komodod) NOTARY_PUBKEY.()
initialized  at 1765601736
Komodo  server starting
nMaxConnections 384
Error: Unable to start HTTP server. See debug log for details.
komodod: /home/smk/GITHUB/gleec/komodo-daemon/depends/x86_64-pc-linux-gnu/share/../include/boost/thread/pthread/mutex.hpp:56: boost::mutex::~mutex(): Assertion `!posix::pthread_mutex_destroy(&m)' failed.

and
2025-12-13 04:59:25 WARNING: option -rpcbind was ignored because -rpcallowip was not specified, refusing to allow everyone to connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants