Open
Conversation
Fixes the case where build_DOWNLOAD (using curl or wget) fails to download the required package from the default URL specified in depends/packages/%recipe_name%.mk. It will then attempt to download from FALLBACK_DOWNLOAD_PATH. This also resolves the macOS CI/CD error "curl: (3) URL rejected: No host part in the URL" noted here: #652. It appears that newer versions of curl included in the latest GitHub runner image exit with an error when FALLBACK_DOWNLOAD_PATH is not set (due to mixed-up variable names FALLBACK_DOWNLOAD_PATH and PRIORITY_DOWNLOAD_PATH in the Makefile). This should now be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the case where build_DOWNLOAD (using curl or wget) fails to download the required package from the default URL specified in depends/packages/%recipe_name%.mk. It will then attempt to download from FALLBACK_DOWNLOAD_PATH. This also resolves the macOS CI/CD error "curl: (3) URL rejected: No host part in the URL" noted here: #652. It appears that newer versions of curl included in the latest GitHub runner image exit with an error when FALLBACK_DOWNLOAD_PATH is not set (due to mixed-up variable names FALLBACK_DOWNLOAD_PATH and PRIORITY_DOWNLOAD_PATH in the Makefile). This should now be fixed.