fix PIRATE wallet loading in case of any txes to notary nodes #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor condition and add bad-txns-acprivate-chain exception for PIRATE. without this in case of any tx to notary node (t-address) exists in the wallet, loading wallet will end up with "All keys read correctly, but transaction data or address book entries might be missing or incorrect." DeckerSU/KomodoOcean@52b65fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor condition and add
bad-txns-acprivate-chainexception for PIRATE. without this in case of any tx to notary node (t-address) exists in the wallet, loading wallet will end up with "All keys read correctly, but transaction data or address book entries might be missing or incorrect."DeckerSU/KomodoOcean@52b65fe
Steps to reproduce without the patch:
You will encounter the message:
"All keys read correctly, but transaction data or address book entries might be missing or incorrect."
With the patch, this behavior is fixed.