Skip to content

Conversation

@ReinisSprogis
Copy link
Contributor

@ReinisSprogis ReinisSprogis commented Sep 18, 2025

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added: Added Lithuanian (lt) and(lv) translations to the resources/locales directory.
  • Reason for change: To expand OpenRouteService language support and make routing instructions available in Latvian and Lithuanian.

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@aoles aoles force-pushed the latvian-lithuanian-translations branch from 99caa15 to 3f34bc6 Compare September 22, 2025 09:58
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! ❤️

In order for some of the checks to pass, would you mind rewriting your commit messages such that they follow the formatting of conventional commits specification. Cheers!

@ReinisSprogis ReinisSprogis changed the title Latvian lithuanian translations feat: Added Latvian and Lithuanian translations Sep 23, 2025
@ReinisSprogis
Copy link
Contributor Author

I don't know what the hell i did with this. Would you mind to help?

@aoles
Copy link
Member

aoles commented Sep 23, 2025

Thanks, I will have a look later.

@aoles aoles self-assigned this Sep 23, 2025
@aoles
Copy link
Member

aoles commented Sep 23, 2025

Dear @ReinisSprogis ,

thanks again for your efforts! ❤️

What happened is that in the pull request I rebased your fork's feature branch on the current upstream GIScience main branch and force-pushed it 🙈 Once the branch diverted on your end you probably tried resolving the issue through merging rather than resetting your local branch to the origin. Cleaning this up requires some git limbo 🤡

Probably the easiest solution would be if you add me as collaborator to your repo such that I can push to it, otherwise I could try to explain what the required steps are 🤓

Looking forward to hearing from you. Cheers!

@ReinisSprogis
Copy link
Contributor Author

Thanks!
Im thinking maybe simpler just to create new PR?

@aoles aoles force-pushed the latvian-lithuanian-translations branch from 424d469 to 29315c7 Compare September 23, 2025 23:20
@aoles
Copy link
Member

aoles commented Sep 24, 2025

No worries, I've managed to clean up this mess 😂 However, as the solution again involved force-pushing, please run the following commands in terminal in order to sync your local repo with github.

git fetch --all
git checkout latvian-lithuanian-translations
git reset --hard origin/latvian-lithuanian-translations

I will continue with the review, so stay tuned. Cheers!

Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for investing your time and energy into the provided translations ❤️

While it's hard for me to completely assess their correctness, I haven't spotted any obvious issues. There are, however, some minor technical aspects which you might still want to improve:

  • please add the new languages to API parameter declarations located in APIEnums.java, see documentation on contributing translations
  • consider adding a link to the PR in your CHANGELOG entry

Don't forget to reset your local branch as advised in my previous comment before committing any changes.

Cheers,
Andrzej

@ReinisSprogis
Copy link
Contributor Author

Hi @aoles , thanks for helping out with this. The translations are the best I could manage. I translated Latvian myself, and Lithuanian was done by someone else. Since I don’t know Lithuanian, I can’t judge its quality, but I suppose it’s better than having no translation at all. If people run into any issues, it might even encourage them to contribute and improve the translations further. I’ve been using both in production for some time and haven’t received any complaints so far.

@aoles aoles force-pushed the latvian-lithuanian-translations branch from 700436f to 66363c5 Compare September 29, 2025 07:50
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@aoles aoles force-pushed the latvian-lithuanian-translations branch from 66363c5 to b31e278 Compare September 30, 2025 11:06
@aoles aoles enabled auto-merge September 30, 2025 11:07
@sonarqubecloud
Copy link

@aoles aoles merged commit fc9058b into GIScience:main Sep 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants