-
Notifications
You must be signed in to change notification settings - Fork 455
feat: Added Latvian and Lithuanian translations #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Latvian and Lithuanian translations #2131
Conversation
99caa15 to
3f34bc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! ❤️
In order for some of the checks to pass, would you mind rewriting your commit messages such that they follow the formatting of conventional commits specification. Cheers!
|
I don't know what the hell i did with this. Would you mind to help? |
|
Thanks, I will have a look later. |
|
Dear @ReinisSprogis , thanks again for your efforts! ❤️ What happened is that in the pull request I rebased your fork's feature branch on the current upstream GIScience main branch and force-pushed it 🙈 Once the branch diverted on your end you probably tried resolving the issue through merging rather than resetting your local branch to the origin. Cleaning this up requires some git limbo 🤡 Probably the easiest solution would be if you add me as collaborator to your repo such that I can push to it, otherwise I could try to explain what the required steps are 🤓 Looking forward to hearing from you. Cheers! |
|
Thanks! |
424d469 to
29315c7
Compare
|
No worries, I've managed to clean up this mess 😂 However, as the solution again involved force-pushing, please run the following commands in terminal in order to sync your local repo with github. git fetch --all
git checkout latvian-lithuanian-translations
git reset --hard origin/latvian-lithuanian-translationsI will continue with the review, so stay tuned. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for investing your time and energy into the provided translations ❤️
While it's hard for me to completely assess their correctness, I haven't spotted any obvious issues. There are, however, some minor technical aspects which you might still want to improve:
- please add the new languages to API parameter declarations located in APIEnums.java, see documentation on contributing translations
- consider adding a link to the PR in your CHANGELOG entry
Don't forget to reset your local branch as advised in my previous comment before committing any changes.
Cheers,
Andrzej
|
Hi @aoles , thanks for helping out with this. The translations are the best I could manage. I translated Latvian myself, and Lithuanian was done by someone else. Since I don’t know Lithuanian, I can’t judge its quality, but I suppose it’s better than having no translation at all. If people run into any issues, it might even encourage them to contribute and improve the translations further. I’ve been using both in production for some time and haven’t received any complaints so far. |
700436f to
66363c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
…n instructions translations
66363c5 to
b31e278
Compare
|



Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)