Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tclune/#3406 cleanup #3408

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Feature/tclune/#3406 cleanup #3408

merged 4 commits into from
Feb 12, 2025

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Feb 11, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune
one
57d809d
@tclune
Fixes #3406
5ac16a5 
Not quite as much cleanup possible as I had imagined.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Feb 11, 2025
@tclune tclune requested a review from pchakraborty February 11, 2025 20:55
@tclune tclune requested a review from a team as a code owner February 11, 2025 20:55
pchakraborty
pchakraborty approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@pchakraborty pchakraborty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pchakraborty pchakraborty merged commit c493089 into release/MAPL-v3 Feb 12, 2025
25 checks passed
@pchakraborty pchakraborty deleted the feature/tclune/#3406-cleanup branch February 12, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchakraborty pchakraborty pchakraborty approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @pchakraborty