Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3305 - support for Bracket exports #3367

Open
wants to merge 2 commits into
base: release/MAPL-v3
Choose a base branch
from
Open

Fixes #3305 - support for Bracket exports #3367

wants to merge 2 commits into from

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Jan 27, 2025

  • This update involved a great many changes to fully integrate ClassAspect from the previous PR. Many tests required updating and some existing logic required updates. (Very little though.)
  • VerticalGridAspect is also simplified.
  • Obsolete code/tests have been removed.
  • Remaining work is to establish a scenario that uses brackets. For this an extension of the ComponentSpecParser is required.
  • Because make_action() needs the src geom (and typekind), the previous implementation needed these stored in VerticalGridAspect. This was a dangerous duplication. Now, the interface of make_action() is extended to have an argument that provides aux aspects such as geom and typekind.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune
Fixes #3305 - support for Bracket exports
24f1340 
- This update involved a great many changes to fully integrate
  ClassAspect from the previous PR.  Many tests required updating and
  some existing logic required updates.  (Very little though.)
- VerticalGridAspect is also simplified.
- Obsolete code/tests have been removed.
- Remaining work is to establish a scenario that uses brackets.  For
  this an extension of the ComponentSpecParser is required.
- Because make_action() needs the src geom (and typekind), the
  previous implementation needed these stored in VerticalGridAspect.
  This was a dangerous duplication.  Now, the interface of
  make_action() is extended to have an argument that provides aux
  aspects such as geom and typekind.
@tclune tclune added 🎁 New Feature This is a new feature 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer 😲 Non 0 Diff The changes in this pull request are non-zero-diff. labels Jan 27, 2025
@tclune tclune requested a review from a team as a code owner January 27, 2025 13:49
atrayano
atrayano approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some diagnostic prints are still left in the code. When all tested, we should remove these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
😲 Non 0 Diff The changes in this pull request are non-zero-diff. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @atrayano