Skip to content

Add ABI kx info#410

Open
rtodling wants to merge 2 commits intoGEOS-FP-5_44from
feature/add_abi_kx4ods
Open

Add ABI kx info#410
rtodling wants to merge 2 commits intoGEOS-FP-5_44from
feature/add_abi_kx4ods

Conversation

@rtodling
Copy link
Copy Markdown
Collaborator

@rtodling rtodling commented Mar 26, 2026

516 and 518 are being assigned to ABI g16 and g18 respectively. Are these acceptable numbers?

see issue #409

@mhan-mars and @gmao-yzhu notice this is not to go on main - that's why there are so many files changed in this PR - I will redirect this to another branch. I just need for you to coordinate with @AustinConaty and confirm that KXs 516 and 518 are acceptable for ABI.

@rtodling rtodling requested review from a team as code owners March 26, 2026 14:25
@github-actions
Copy link
Copy Markdown

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged.

@rtodling rtodling requested review from gmao-yzhu and mhan-mars March 26, 2026 14:27
@mhan-mars
Copy link
Copy Markdown

We may want to specify this is for ABI radiance. It's is better to differentiate them from ABI wind. Also, we should reserve a number for ABI radiance on GOES 19.

@mathomp4
Copy link
Copy Markdown
Member

@rtodling do you know what branch this should go into?

@rtodling rtodling changed the base branch from main to GEOS-FP-5_44 March 26, 2026 14:39
@mhan-mars
Copy link
Copy Markdown

mhan-mars commented Mar 26, 2026 via email

@rtodling
Copy link
Copy Markdown
Collaborator Author

@rtodling do you know what branch this should go into?

I just added the branch - GEOS-FP-5_44 ... not sure why the adding the branch requires a PR - but there is PR now on adding GEOS-FP-5_44 ... thanks.

@github-actions
Copy link
Copy Markdown

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link
Copy Markdown

@AustinConaty AustinConaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ricardo,
It's times like this I miss Jing Guo. He was the chief knowledge officer when it came to KX/KT combinations. It looks to me like KX=516 and KX=518 will work fine for abi_g16 and abi_g18. Thanks,Austin

@github-actions
Copy link
Copy Markdown

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link
Copy Markdown

@gmao-yzhu gmao-yzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me.

@gmao-yzhu
Copy link
Copy Markdown

516 and 518 are being assigned to ABI g16 and g18 respectively. Are these acceptable numbers?

see issue #409

@mhan-mars and @gmao-yzhu notice this is not to go on main - that's why there are so many files changed in this PR - I will redirect this to another branch. I just need for you to coordinate with @AustinConaty and confirm that KXs 516 and 518 are acceptable for ABI.

idsats is set to 500, it's fine to me. so 516 and 518 are acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants