Use LongName for FP collection descriptions in pyrob#408
Draft
Use LongName for FP collection descriptions in pyrob#408
Conversation
For Forward Processing (-F) runs, pyrob now derives the collection description from the LongName global attribute of the netCDF file, stripping any leading 'GEOS FP ' prefix and title-casing the result. A new --no-longname flag restores the legacy Title-based behaviour for older FP (and GEOS-IT) files that predate the LongName attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per a request of @rlucches, for Forward Processing (
-F) runs,pyrobnow derives the collection description from the LongName global attribute of the netCDF file, stripping any leading 'GEOS FP ' prefix and title-casing the result.A new
--no-longnameflag restores the legacy Title-based behavior for older FP (and GEOS-IT) files that predate the LongName attribute.I tested this on a couple files:
Old behavior (
--no-longname):New default behavior (from LongName global attribute):