Add protections on aer_props passed to RRTMGP #60
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crap. Bug in CI. Let me look at it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
This PR adds protections on some aerosol properties passed to RRTMGP. Because RRTMGP is (currently) compiled at R8, _wp is R8. Apparently with aggressive compiler flags, it's possible for, say, aer_props%ssa to become slightly greater than one in the above renormalization.
So, we add clamps to the values based on the restrictions seen in https://github.com/GEOS-ESM/rte-rrtmgp/blob/1163c8c608a341987c2647dfa540481688c064bc/rte-frontend/mo_optical_props.F90#L645-L652
In testing, the values seen were like 1.00000011905028 so just slightly above one.
I've labeled as non-zero-diff because, well, this could change answers.