Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline choice for landice_gridcomp #909

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Add offline choice for landice_gridcomp #909

wants to merge 9 commits into from

Conversation

weiyuan-jiang
Copy link
Contributor

The PR prepares landice_gridcomp to run offline with catch_gridcomp

@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 23, 2024
@gmao-rreichle gmao-rreichle added the enhancement New feature or request label Jan 29, 2025
@gmao-rreichle gmao-rreichle mentioned this pull request Jan 29, 2025
Open
@biljanaorescanin biljanaorescanin marked this pull request as ready for review January 30, 2025 01:16
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner January 30, 2025 01:16
@biljanaorescanin
Copy link
Contributor

All associated tests were zero diff.

  1. GEOSldas regression testing zero diff.
  2. GCM 1-day AMIP, REPLAY and Inc REPLAY all zero diff.

@sdrabenh this PR is ready for you.

lcandre2
lcandre2 approved these changes Jan 30, 2025
View reviewed changes
Copy link

@lcandre2 lcandre2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but will still need to do some science changes.

@biljanaorescanin biljanaorescanin mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcandre2 lcandre2 lcandre2 approved these changes

@biljanaorescanin biljanaorescanin biljanaorescanin approved these changes

Assignees

@biljanaorescanin biljanaorescanin

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiyuan-jiang @biljanaorescanin @lcandre2 @gmao-rreichle