added support for CICE6 thermo state rewind for replay #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaobin74
added
the
0 diff
yvikhlya
approved these changes
Nov 15, 2023
|
@sdrabenh I got a confirmation from @zhaobin74 that he verified in both configurations:
I'll not be reviewing this PR. |
Sounds good. My AGCM tests passed... but obviously not a test of CICE |
sdrabenh
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a customized entry point method to support restoring CICE6 state variables such that they can be reset before
correctorstep starts. The reason for saving and restoring CICE6 states is thatpredictorstep updates these states via callbacks even though theseaice_gridcompis not running.This PR also fixed a bug in
Recordmethod which doesn't handle dumping MAPL states properly.This PR is zero diff and it depends on GEOS-ESM/GEOSgcm#702