Closed
Conversation
mathomp4
added
the
0 diff
This was referenced Apr 22, 2026
Collaborator
|
I believe this can be closed because of FlorianDeconinck#13 flowing into #1231 - which will bring the dependency removal to bear |
Member
Author
Very true! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1231 from @FlorianDeconinck introduces a library dependence on FMS (due to moving to a shared library). This is not good for the rest of GEOS.
However, v12 no longer cares about FMS as the GFDL microphysics in there converted FMS and MPP calls to Fortran and MAPL. So we do the same here. If this works, then @FlorianDeconinck can use the same changes in his branch.
It is zero-diff. So I'll undraft but if these changes are put into #1231 by @FlorianDeconinck then this can be closed.