Auto PR - develop → MAPL-v3 - remove filling of WET1 (a.k.a. GWETTOP) with 1s over non-land (GEOS_SurfaceGridComp.F90) #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…urfaceGridComp.F90)
…ove_WET1_filling # Conflicts: # GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90
Bug fix: Previously, minimal CAPAC values were converted into runoff by adding them directly into total RUNOFF, but not into one of its components (RUNSRF or BFLOW), which violated the definition of total RUNOFF (=RUNSRF + BFLOW). This fix adds the minimal CAPAC into RUNSRF and thus preserves the equation of total RUNOFF.
Bug fix (CatchCN): Previously, minimal CAPAC values were converted into runoff by adding them directly into total RUNOFF, but not into one of its components (RUNSRF or BFLOW), which violated the definition of total RUNOFF (=RUNSRF + BFLOW). This fix adds the minimal CAPAC into RUNSRF and thus preserves the equation of total RUNOFF.
…ling remove filling of WET1 (a.k.a. GWETTOP) with 1s over non-land
github-actions
bot
added
automatic
…inimal_CAPAC_to_RUNOFF Fixed conversion of minimal CAPAC to RUNOFF (catchment.F90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Automatic PR:
develop→release/MAPL-v3Description
remove filling of WET1 (a.k.a. GWETTOP) with 1s over non-land (GEOS_SurfaceGridComp.F90)
📁 Modified files
.../GEOSphysics_GridComp/GEOS_PhysicsGridComp.F90 | 24 +-
.../GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90 | 912 +++++++++++----------
.../GEOScatchCN_GridComp/Shared/catchmentCN.F90 | 4 +-
.../GEOScatch_GridComp/catchment.F90 | 4 +-
4 files changed, 489 insertions(+), 455 deletions(-)