-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/#318 : 꿀팁 페이지 라우팅 추가 & 홈 화면 디자인 수정 #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 채용, 어학, 꿀팁 카드의 UI가 비슷해 재활용 할 수 있도록 리팩토링 진행 - asset props는 render props로써 외부에서 주입 하는 JSX를 반환하는 컴포넌트를 props로 받아 렌더링하기 때문에 유연하게 사용할 수 있게 됨.
- 학교, 학과 공지사항 & 졸업요건
- 취업, 어학, 꿀팁
Closed
pp449
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#320 추가 반영 부탁드려요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
💫 설명
InformHalfCard
컴포넌트를 재사용하기 위해서 render props를 활용했어요이렇게 한 이유는
Icon
컴포넌트 사용Image
컴포넌트 사용두 종류의 카드 컴포넌트의 UI가 동일한데 다른 에셋을 사용한다고 해서 두개의 컴포넌트를 따로 만들고 싶지 않아서 render props를 활용했어요
WebpImage
컴포넌트를 추가로 구현해서 재사용할 수 있도록 했어요 (TipImage) 컴포넌트에서 재사용중이에요IVORY
에서WHITE
로 변경했어요,box-shadow
를 사용해서 배경과 구분해요📷 스크린샷 (Optional)