Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#320: 자잘한 UI 수정 #321

Closed
wants to merge 2 commits into from
+6 −4
Closed

Fix/#320: 자잘한 UI 수정 #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76938ff
fix(InformSearchForm): 검색창 글자 색 변경
pp449 Feb 2, 2024
fea7f1a
fix(InformHalfCard): 메인 화면의 HalfCard 의 글자크기 조절
pp449 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/InformUpperLayout/InformSearchForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import TOAST_MESSAGES from '@constants/toast-message';
import styled from '@emotion/styled';
import useRouter from '@hooks/useRouter';
import useToasts from '@hooks/useToast';
import { THEME } from '@styles/ThemeProvider/theme';
import React, { useRef } from 'react';

interface InformSearchForm {
Expand Down Expand Up @@ -60,12 +61,12 @@ const StyledInput = styled.input`
border: 0;
border-radius: 15px;
background-color: #7a9dd30f;
color: #7a9dd366;
color: ${THEME.TEXT.BLACK};
font-size: 14px;
text-indent: 5px;

&::placeholder {
color: #7a9dd366;
color: ${THEME.TEXT.GRAY};
font-size: 14px;
}
box-shadow: 0px 0px 5px rgba(0, 0, 0, 0.15);
Expand Down
5 changes: 3 additions & 2 deletions src/pages/Home/components/InformHalfCard.tsx
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이 부분 수정 중이라 충돌 날 것 같은데 제가 작업 마무리 하는걸로 할까요?
취업, 어학 정보 카드 컴포넌트 밑에서 사용하는 꿀팁 페이지 이동 카드 컴포넌트도 UI가 비슷해서 같은 컴포넌트로 묶으려고 하고 있는데 이 작업에서 같이 마무리하면 될 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러면 #322 작업에서 해당 내용 반영 부탁드릴게요
해당 작업은 merge 하지 않고 나중에 모두 반영되면 close 처리할게요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다

Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,15 @@ const TitleWrapper = styled.div`
`;

const Title = styled.h2`
font-size: 16px;
font-size: 14px;
white-space: nowrap;
font-weight: bold;
`;

const SubTitle = styled.h3`
color: ${THEME.TEXT.SEMIBLACK};
display: flex;
justify-content: flex-end;
font-size: 13px;
font-size: 11px;
padding-bottom: 6px;
`;
Loading