Feat/#306: 채용공지사항 기능 추가 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
채용 공지는 다른 공지와는 다르게 공지 업로드 날짜가 아닌 채용 기간을 보여주기로 결정했기에 날짜에 대한 변수값이 달라요 그렇기에 해당 변수명도 props 로 받아 보여질 수 있도록 하였고 채용 공지의 경우 작성자가 보이지 않도록 했어요
hwinkr
approved these changes
Jan 5, 2024
| } | ||
|
|
||
| const AnnounceCard = ({ | ||
| title, | ||
| link, | ||
| uploadDate, | ||
| recruitment_period, |
There was a problem hiding this comment.
AnnounceCard 컴포넌트가 받는 props가 점점 더 많아지고 있는 것 같네요...
이 컴포넌트도 합성 컴포넌트 패턴을 적용하면 더 유연하게 대처할 수 있을 것 같아요.
다른 공지사항들도 AnnounceCard 컴포넌트를 사용하고, 또 다른 props를 추가로 전달해야 한다면
이 상황이 필요한 모달들(ConfirmModal, AlertModal, SuggestionModal)을 모두 만들었던 이전의 상황과 비슷해지고 있다는 생각이 들어서 다음 회의 때 한번 얘기 나눠보면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
💫 설명
📷 스크린샷 (Optional)