Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/#300 : 건의사항 페이지에서 사용하는 모달을 합성 컴포넌트로 변경 #301

Merged
merged 1 commit into from
Dec 28, 2023
Merged

chore/#300 : 건의사항 페이지에서 사용하는 모달을 합성 컴포넌트로 변경 #301

merged 1 commit into from
Dec 28, 2023

Conversation

hwinkr
Copy link
Collaborator

@hwinkr hwinkr commented Dec 28, 2023

  • 건의사항을 보낼 때 한번 더 내용을 확인하는 로직 추가

🤠 개요

💫 설명

  • 건의사항에서 사용하는 모달을 합성 컴포넌트로 변경했어요.
  • 건의사항을 보내기 전에 한번더 내용을 확인하는 모달을 띄우는 것으로 유지하기로 했어요.

📷 스크린샷 (Optional)

@hwinkr
chore(change modal code): 건의사항 페이지에서 사용하는 모달을 합성 컴포넌트로 변경
68e5948 
- 건의사항을 보낼 때 한번 더 내용을 확인하는 로직 추가
@hwinkr hwinkr requested a review from pp449 December 28, 2023 11:40
@hwinkr hwinkr self-assigned this Dec 28, 2023
pp449
pp449 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD~!

@hwinkr hwinkr merged commit 3ff3f68 into dev Dec 28, 2023
1 check passed
@hwinkr hwinkr deleted the chore/#300 branch December 28, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@hwinkr hwinkr

Labels
⚒️ chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: 건의사항 페이지에서 사용하는 모달 합성 컴포넌트로 변경
2 participants
@hwinkr @pp449