Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/#294 : 건의사항 페이지 구현 #299

Merged
merged 3 commits into from
Dec 28, 2023
Merged

feat/#294 : 건의사항 페이지 구현 #299

merged 3 commits into from
Dec 28, 2023

Conversation

hwinkr
Copy link
Collaborator

@hwinkr hwinkr commented Dec 23, 2023

🤠 개요

💫 설명

📷 스크린샷 (Optional)

@hwinkr hwinkr self-assigned this Dec 23, 2023
pp449
pp449 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 좋아요~

#293 이 반영되지 않아서 나중에 머지되면 모달은 합성 컴포넌트로 변경해야돼요

해당 작업은 따로 이슈를 만들어서 작업하나요?

@hwinkr hwinkr merged commit d98b449 into dev Dec 28, 2023
1 check passed
@hwinkr hwinkr deleted the feat/#298 branch December 28, 2023 10:59
@hwinkr
Copy link
Collaborator Author

hwinkr commented Dec 28, 2023

✅ 좋아요~

#293 이 반영되지 않아서 나중에 머지되면 모달은 합성 컴포넌트로 변경해야돼요

해당 작업은 따로 이슈를 만들어서 작업하나요?

따로 이슈를 만들기에는 너무 작은 작업이라서, 아마 마이페이지에 기능 추가할 때 같이 하면 될 것 같아요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@hwinkr hwinkr

Labels
✨ feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: 건의사항 페이지 구현
2 participants
@hwinkr @pp449