Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#294: MajorProvider에서 졸업요건 링크 상태 삭제 #295

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Refactor/#294: MajorProvider에서 졸업요건 링크 상태 삭제 #295

merged 4 commits into from
Dec 12, 2023

Conversation

hwinkr
Copy link
Collaborator

@hwinkr hwinkr commented Dec 11, 2023

🤠 개요

💫 설명

  • MajorProvider에서 Context API를 사용해 졸업요건 링크 상태를 의존성으로 주입했던 로직을 삭제했어요.
  • 대신, 졸업요건 카드를 클릭할 때마다 졸업요건 링크를 가져오는 api 요청을 보내고 해당링크로 이동 시키는 로직을 InformCardList 컴포넌트에 추가했어요

📷 스크린샷 (Optional)

@hwinkr hwinkr requested a review from pp449 December 11, 2023 03:02
@hwinkr hwinkr self-assigned this Dec 11, 2023
pp449
pp449 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅LGTM
좋아요~~

@hwinkr hwinkr merged commit 90efaca into dev Dec 12, 2023
1 check passed
@hwinkr hwinkr deleted the refactor/#294 branch December 12, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp449 pp449 pp449 approved these changes

Assignees

@hwinkr hwinkr

Labels
⚒️ chore 🧑‍🔧 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: useMajor 훅에서 졸업요건 링크 삭제
2 participants
@hwinkr @pp449