Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#320: 자잘한 UI 수정 #321

Closed
wants to merge 2 commits into from
Closed

Fix/#320: 자잘한 UI 수정 #321

wants to merge 2 commits into from

Conversation

pp449
Copy link
Member

@pp449 pp449 commented Feb 2, 2024

🤠 개요

  • closes: Fix: 자잘한 UI 변경 #320
  • Input 컴포넌트의 색상을 placeholder 는 회색, 글자는 검은색으로 수정
  • 홈 화면의 HalfCard 컴포넌트의 글자가 2줄로 처리되지 않도록 수정

💫 설명

📷 스크린샷 (Optional)

image

pp449 added 2 commits February 3, 2024 03:10
placeholder 는 회색, 입력하는 텍스트는 검은색으로 설정
해상도에 따라 글자를 2줄로 처리되지 않고 1줄로 처리하도록 수정
@pp449 pp449 added the 🛠 fix label Feb 2, 2024
@pp449 pp449 requested a review from hwinkr February 2, 2024 18:13
@pp449 pp449 self-assigned this Feb 2, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이 부분 수정 중이라 충돌 날 것 같은데 제가 작업 마무리 하는걸로 할까요?
취업, 어학 정보 카드 컴포넌트 밑에서 사용하는 꿀팁 페이지 이동 카드 컴포넌트도 UI가 비슷해서 같은 컴포넌트로 묶으려고 하고 있는데 이 작업에서 같이 마무리하면 될 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러면 #322 작업에서 해당 내용 반영 부탁드릴게요
해당 작업은 merge 하지 않고 나중에 모두 반영되면 close 처리할게요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다

@pp449 pp449 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: 자잘한 UI 변경
2 participants