Skip to content

Merge develop to master #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CSE-Shaco merged 9 commits into from
Dec 9, 2025
Merged

Merge develop to master #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5ebe10
Add Google Maps API key to deployment workflow
CSE-Shaco Dec 8, 2025
e34cbe9
Merge pull request #211 from GDGoCINHA/master
CSE-Shaco Dec 9, 2025
202f191
[ImgBot] Optimize images
ImgBotApp Dec 9, 2025
97f16a2
fix(homecoming): typo 수정
CSE-Shaco Dec 9, 2025
62979dd
Merge pull request #213 from CSE-Shaco/develop
CSE-Shaco Dec 9, 2025
f735af2
Merge pull request #212 from GDGoCINHA/imgbot
CSE-Shaco Dec 9, 2025
e985490
Include GOOGLE_MAPS_API_KEY in deploy workflow
CSE-Shaco Dec 9, 2025
eae9636
fix(homecoming): 디버깅을 위한 코드 추가
CSE-Shaco Dec 9, 2025
9e08ff5
Merge pull request #214 from CSE-Shaco/develop
CSE-Shaco Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,23 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'yarn' # yarn.lock 기반 자동 캐시
cache: 'yarn'

- name: Set env for develop
if: github.ref == 'refs/heads/develop'
run: |
echo "TARGET_BUCKET=${{ secrets.AWS_S3_BUCKET_DEV }}" >> $GITHUB_ENV
echo "NEXT_PUBLIC_APP_ENV=dev" >> $GITHUB_ENV
echo "NEXT_PUBLIC_BASE_API_URL=${{ secrets.NEXT_PUBLIC_BASE_API_URL_DEV }}" >> $GITHUB_ENV
echo "NEXT_PUBLIC_GOOGLE_MAPS_API_KEY=${{ secrets.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY }}" >> $GITHUB_ENV

- name: Set env for main
if: github.ref == 'refs/heads/master'
run: |
echo "TARGET_BUCKET=${{ secrets.AWS_S3_BUCKET }}" >> $GITHUB_ENV
echo "NEXT_PUBLIC_APP_ENV=production" >> $GITHUB_ENV
echo "NEXT_PUBLIC_BASE_API_URL=${{ secrets.NEXT_PUBLIC_BASE_API_URL }}" >> $GITHUB_ENV
echo "NEXT_PUBLIC_GOOGLE_MAPS_API_KEY=${{ secrets.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY }}" >> $GITHUB_ENV

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand Down
Binary file modified public/icons/logo/chatgpt.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/icons/logo/django.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/icons/logo/figma.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/activity/buildwithai.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/activity/seminar_bg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/homecoming/bg.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/homecoming/main_img.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 7 additions & 2 deletions src/app/homecoming/page.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@

{/* 2번째 문장: 굵은 부분은 데스크탑에서 따로 줄바꿈 */}
<p>
이번 행사는 현역 부원과 OB, 그리고 GDG 커뮤니티에 관심 있는 모든 분들이 한자리에 모여
이번 행사는 현역 부원과 OB, 그리고 GDG 커뮤니티에 관심 있는 모든 분들이 한자리에 모여{" "}
<br className="hidden md:block"/>
<span className="font-semibold">
프로젝트 성과 공유 · 기술 교류 · 커뮤니티 네트워킹
Expand All @@ -132,7 +132,7 @@

{/* 3번째 문장 */}
<p>
한 해 동안의 활동을 돌아보고, 앞으로 GDGoC INHA가 만들어갈 방향을 함께 이야기하며
한 해 동안의 활동을 돌아보고, 앞으로 GDGoC INHA가 만들어갈 방향을 함께 이야기하며{" "}
<br className="hidden md:block"/>
커뮤니티의 가치를 더욱 확장하는 의미 있는 시간을 준비했습니다.
</p>
Expand Down Expand Up @@ -222,6 +222,11 @@
googleMapsApiKey: process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY, id: 'homecoming-map-script',
});

console.log(
"MAPS KEY PREFIX:",
process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY?.slice(0, 10)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This logs sensitive data returned by
an access to NEXT_PUBLIC_GOOGLE_MAPS_API_KEY
Loading
as clear text.

Copilot Autofix

AI 3 months ago

To address this logging of sensitive information, all code that logs (or otherwise exposes) any part of the NEXT_PUBLIC_GOOGLE_MAPS_API_KEY variable should be removed, especially the console statement on line 227. Simply remove the console.log block (lines 225-228) from the HomecomingMap function in src/app/homecoming/page.jsx. No imports, method replacements, or variable substitutions are required—just deleting the logging code is sufficient. This change will prevent the accidental or intentional logging of any part of the sensitive API key.

Suggested changeset 1
src/app/homecoming/page.jsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/app/homecoming/page.jsx b/src/app/homecoming/page.jsx
--- a/src/app/homecoming/page.jsx
+++ b/src/app/homecoming/page.jsx
@@ -222,11 +222,8 @@
         googleMapsApiKey: process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY, id: 'homecoming-map-script',
     });
 
-    console.log(
-        "MAPS KEY PREFIX:",
-        process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY?.slice(0, 10)
-    );
 
+
     const center = {lat: 37.388493, lng: 126.639989};
 
     if (loadError) {
EOF
@@ -222,11 +222,8 @@
googleMapsApiKey: process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY, id: 'homecoming-map-script',
});

console.log(
"MAPS KEY PREFIX:",
process.env.NEXT_PUBLIC_GOOGLE_MAPS_API_KEY?.slice(0, 10)
);


const center = {lat: 37.388493, lng: 126.639989};

if (loadError) {
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
);

const center = {lat: 37.388493, lng: 126.639989};

if (loadError) {
Expand Down