Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI/CD scripts to prevent conflicts when running multiple projects simultaneously. The changes include:
- Updating appspec.yml to use the gdgocinha-fe subdirectory for files and deploy hooks.
- Modifying the deploy workflow to create a structured deployment package with separate directories (including nginx and logs).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| appspec.yml | Updated file paths and permissions to target the gdgocinha-fe subdirectory. |
| .github/workflows/deploy.yml | Revised deployment package creation including new directory structure and file locations. |
Comments suppressed due to low confidence (2)
appspec.yml:13
- The updated deploy script path now reflects the new subdirectory structure; please verify that this change is consistent with the deployment package structure defined in the workflow.
+ - location: gdgocinha-fe/deploy.sh
.github/workflows/deploy.yml:60
- [nitpick] Ensure that zipping the package from the deploy-package directory does not inadvertently include any unintended files and that the resulting structure meets the production deployment requirements.
+ zip -r ../deploy-gdgocinha-fe.zip .
Comment on lines
+37
to
+53
| mkdir -p deploy-package/gdgocinha-fe | ||
|
|
||
| # Copy necessary files | ||
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ | ||
| cp docker-compose.yml deploy-package/gdgocinha-fe/ | ||
| cp appspec.yml deploy-package/gdgocinha-fe/ | ||
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ | ||
|
|
||
| # Copy nginx configuration | ||
| mkdir -p deploy-package/gdgocinha-fe/nginx | ||
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ | ||
|
|
||
| # Create logs directory | ||
| mkdir -p deploy-package/gdgocinha-fe/logs | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/docker | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/app | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy |
There was a problem hiding this comment.
[nitpick] Consider adding additional comments to explain the purpose of each newly created directory (e.g., nginx and logs) to improve maintainability.
Suggested change
| mkdir -p deploy-package/gdgocinha-fe | |
| # Copy necessary files | |
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ | |
| cp docker-compose.yml deploy-package/gdgocinha-fe/ | |
| cp appspec.yml deploy-package/gdgocinha-fe/ | |
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ | |
| # Copy nginx configuration | |
| mkdir -p deploy-package/gdgocinha-fe/nginx | |
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ | |
| # Create logs directory | |
| mkdir -p deploy-package/gdgocinha-fe/logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/docker | |
| mkdir -p deploy-package/gdgocinha-fe/logs/app | |
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy | |
| mkdir -p deploy-package/gdgocinha-fe # Root directory for the deployment package | |
| # Copy necessary files | |
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ # Deployment script | |
| cp docker-compose.yml deploy-package/gdgocinha-fe/ # Docker Compose configuration | |
| cp appspec.yml deploy-package/gdgocinha-fe/ # AWS CodeDeploy configuration | |
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ # Environment variables | |
| # Copy nginx configuration | |
| mkdir -p deploy-package/gdgocinha-fe/nginx # Directory for nginx configuration files | |
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ # Main nginx configuration file | |
| # Create logs directory | |
| mkdir -p deploy-package/gdgocinha-fe/logs # Root directory for application logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/docker # Directory for Docker-related logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/app # Directory for application-specific logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy # Directory for deployment process logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용