Deploy(#102) Fix(#96, #116)/ refactored study, enhance special components and update SEO#119
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the study pages and related components, updates the API services, enhances special components, and revises metadata/SEO settings for the deployment.
- Removed the MarginBottom component and redundant spinner-based loading logic across study pages.
- Updated API service imports and error handling components along with numerous UI refinements and metadata improvements.
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/MarginBottom.jsx | Removed unused component. |
| src/app/unauthorized.js | Added an experimental unauthorized page implementation. |
| src/app/study/page.jsx | Refactored import statements and removed loading spinner. |
| src/app/study/detail/[id]/page.jsx | Updated API service import and removed spinner condition. |
| src/app/study/create/page.jsx | Modified the multipart API request and removed isLoading logic. |
| src/app/study/apply/[id]/page.jsx | Refactored layout and import statements, removed spinner logic. |
| src/app/study/(dashboard)/my/page.jsx | Removed spinner logic in favor of a static dashboard layout. |
| src/app/study/(dashboard)/my/[id]/page.jsx | Simplified state management by removing spinner logic. |
| src/app/study/(dashboard)/admin/page.jsx | Similar dashboard refactor, spinner logic removed. |
| src/app/study/(dashboard)/admin/[id]/page.jsx | Simplified state and UI by removing spinner logic. |
| src/app/not-found.jsx and src/app/not-found.js | Replaced with updated not-found pages with consistent design. |
| src/app/loading.js | Added a new loading component with animation and proper styling. |
| src/app/layout.js | Enhanced metadata, applied PWA meta tags, and added an error boundary. |
| src/app/forbidden.js | Introduced a new forbidden access page with consistent styling. |
| src/app/error.js | Updated error UI with a countdown and conditional rendering based on error code. |
| public/manifest.json | Revised manifest metadata and icons with minor changes in icon dimensions. |
| package.json | Updated dependency versions with minor version range adjustments. |
Comments suppressed due to low confidence (1)
public/manifest.json:37
- The icon size in the manifest has been changed from a square dimension (previously "144x144") to "144x70". Please verify if this non-square size is intentional, as it may impact how icons are displayed on certain devices.
"sizes": "144x70",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용