feat(recruit-member): align answer input types and persist proof file…#300
Merged
CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom Feb 14, 2026
Merged
feat(recruit-member): align answer input types and persist proof file…#300CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom
CSE-Shaco merged 1 commit intoGDGoCINHA:developfrom
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough모집 멤버 신청 프로세스에 파일 업로드 기능이 추가되었습니다. 컨트롤러에서 MultipartFile 파라미터를 받아 서비스로 전달하고, 서비스에서 파일을 S3에 업로드 후 URL을 신청 답변에 저장합니다. InputType enum이 확장되고 최적화되었으며, 페이로드 처리 로직이 리팩토링되었습니다. Changes
Sequence DiagramsequenceDiagram
participant Client
participant RecruitMemberController
participant RecruitMemberService
participant S3Service
participant Database
Client->>RecruitMemberController: POST /recruit/member (file + applicationRequest)
alt With File (recruitMemberAddMultipart)
RecruitMemberController->>RecruitMemberService: addRecruitMember(applicationRequest, file)
else Without File (recruitMemberAdd)
RecruitMemberController->>RecruitMemberService: addRecruitMember(applicationRequest, null)
end
alt File is Present
RecruitMemberService->>S3Service: uploadProofFile(file)
S3Service-->>RecruitMemberService: proofFileUrl
RecruitMemberService->>RecruitMemberService: answers.put("proofFileUrl", url)
end
RecruitMemberService->>RecruitMemberService: buildMemberFromNumberedPayload(payload)
RecruitMemberService->>RecruitMemberService: buildAnswersFromNumberedPayload(payload)
RecruitMemberService->>Database: Save Member & Answers
Database-->>RecruitMemberService: Success
RecruitMemberService-->>RecruitMemberController: Complete
RecruitMemberController-->>Client: Response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… upload
📌 연관된 이슈
✨ 작업 내용
💬 리뷰 요구사항(선택)
Summary by CodeRabbit
릴리스 노트
New Features
Improvements