Skip to content

Update target frameworks for test projects #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2025
Merged

Update target frameworks for test projects #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d33917
Update target frameworks for test projects
adamreeve Sep 24, 2025
0bc7d78
Specify framework when building test projects in native build job
adamreeve Sep 24, 2025
e9b50e8
Install dotnet 9.0 SDK in native build job
adamreeve Sep 24, 2025
c58572b
Update to .net9 in global.json and CI
adamreeve Sep 25, 2025
dfffd5b
Update devcontainer base image
adamreeve Sep 25, 2025
5824cd3
Update .net sdk in codeql workflow
adamreeve Sep 25, 2025
e3ad10e
Merge branch 'master' into dotnet9-tests
adamreeve Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/devcontainers/dotnet:1-8.0-bookworm-slim AS dotnet
FROM mcr.microsoft.com/devcontainers/dotnet:1-9.0-bookworm-slim AS dotnet

#====================================================================

Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v5
- name: Setup .NET SDK v8.0.x
- name: Setup .NET SDK v9.0.x
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x
- name: Code formating check
run: |
dotnet tool restore
Expand Down Expand Up @@ -133,10 +133,10 @@ jobs:
run: brew install bison

# .NET Setup (and also MSBuild for Windows).
- name: Setup .NET SDK v8.0.x
- name: Setup .NET SDK v9.0.x
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x
- name: Setup MSBuild
if: runner.os == 'Windows'
uses: microsoft/setup-msbuild@v2
Expand Down Expand Up @@ -200,10 +200,10 @@ jobs:
run: |
mkdir bin
cp -rv artifacts/*-native-library/* bin/
- name: Setup .NET SDK v8.0.x
- name: Setup .NET SDK v9.0.x
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x
- name: Get version
id: get-version
shell: pwsh
Expand Down Expand Up @@ -254,11 +254,11 @@ jobs:
with:
dotnet-version: 6.0.x
- name: Setup .NET SDK v8.0.x
if: matrix.dotnet == 'net8.0'
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
- name: Setup .NET SDK v9.0.x
if: matrix.dotnet == 'net9.0'
uses: actions/setup-dotnet@v5
with:
dotnet-version: 9.0.x
Expand Down Expand Up @@ -327,10 +327,10 @@ jobs:
with:
name: nuget-package
path: nuget
- name: Setup .NET SDK v8.0.x
- name: Setup .NET SDK v9.0.x
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x
# if version contains "-" treat it as pre-release
# example: 1.0.0-beta1
- name: Create release
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ jobs:
cd $VCPKG_INSTALLATION_ROOT
./bootstrap-vcpkg.sh

- name: Setup .NET SDK v8.0.x
- name: Setup .NET SDK v9.0.x
uses: actions/setup-dotnet@v5
with:
dotnet-version: 8.0.x
dotnet-version: 9.0.x

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
4 changes: 2 additions & 2 deletions csharp.test/ParquetSharp.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<!-- Avoid building for older frameworks when testing locally. -->
<!-- Avoid building for other frameworks when testing locally. -->
<!-- This is to speed up the build process and avoid errors when the required runtimes are not installed. -->
<TargetFrameworks Condition="'$(CI)' == 'true'">$(TargetFrameworks);netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks Condition="'$(CI)' == 'true'">$(TargetFrameworks);net6.0;net9.0</TargetFrameworks>
<TargetFrameworks Condition="'$(CI)' == 'true' AND '$(OS)'=='Windows_NT'">$(TargetFrameworks);net472</TargetFrameworks>
<LangVersion>9.0</LangVersion>
<Nullable>enable</Nullable>
Expand Down
4 changes: 2 additions & 2 deletions fsharp.test/ParquetSharp.Test.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<!-- Avoid building for older frameworks when testing locally. -->
<!-- Avoid building for other frameworks when testing locally. -->
<!-- This is to speed up the build process and avoid errors when the required runtimes are not installed. -->
<TargetFrameworks Condition="'$(CI)' == 'true'">$(TargetFrameworks);netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFrameworks Condition="'$(CI)' == 'true'">$(TargetFrameworks);net6.0;net9.0</TargetFrameworks>
<TargetFrameworks Condition="'$(CI)' == 'true' AND '$(OS)'=='Windows_NT'">$(TargetFrameworks);net472</TargetFrameworks>
<PlatformTarget Condition="'$(TargetFramework)'=='net472'">x64</PlatformTarget>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"version": "9.0.109",
"rollForward": "latestMinor"
}
}