Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-1-final #1613

Open
wants to merge 1 commit into
base: os-1-final
Choose a base branch
from
Open

os-1-final #1613

wants to merge 1 commit into from

Conversation

davneesh
Copy link

@davneesh davneesh commented Jun 22, 2024

Issue that this pull request solves

Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@prajjwalkapoor
Copy link

@davneesh Can you merge the latest_staging changes into your branch and direct this PR directly into latest_staging for merging?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is change in code of other module, verify it @prajjwalkapoor

@prajjwalkapoor
Copy link

@davneesh ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants