Inverse solver: enabling second order magnetic null constraints (for snowflake divertors)#56
Merged
Merged
Conversation
kpentland
added
ready-for-final-tests
kpentland
added
ready-for-final-tests
Contributor
|
Sorry @kpentland I forgot about this, I have put it on my list for review tomorrow! |
timothy-nunn
suggested changes
Apr 15, 2026
timothy-nunn
suggested changes
May 6, 2026
added 2 commits
May 14, 2026 10:24
kpentland
added
the
ready-for-final-tests
Collaborator
Author
|
Thanks again for looking this over @timothy-nunn - hopefully looks ok now. |
timothy-nunn
approved these changes
May 15, 2026
kpentland
added
ready-for-final-tests
kpentland
added
ready-for-final-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to being able to set first order magnetic null constraints in the inverse solver, we've now added functionality for setting second order null constraints. This is particularly useful for making snowflake divertor geometries.
There are updates to the Example01b notebook for how to use these constraints and an example snowflake equilibrium.
Note that this requires PR 50 in FreeGS4E.